Unify VolumeRGB and VertexRGB signatures (fixes #579)#599
Open
Unify VolumeRGB and VertexRGB signatures (fixes #579)#599
Conversation
… rejection (issue #579)
…ering - Remove **kwargs from VolumeRGB docstring (no longer accepted) - Filter kwargs in _from_hdf_data for old-style RGB volumes to avoid passing unsupported params (cmap, vmin, vmax) to RGB constructors
- Fix docstring typo: "vim" -> "vmin" in VolumeRGB - Fix error message: channel 3 validation said "channel 2" - Add priority param to VertexRGB docstring - Consistent kwargs filtering style in _from_hdf_view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color_voxelsstatic method fromVolumeRGBtoDataviewRGBbase class, generalized forVertexDataVertexRGB:shared_range,shared_vmin,shared_vmax, custom channel colors (channel1color,channel2color,channel3color), and HSV controls (max_color_value,max_color_saturation)**kwargsfromDataviewRGB,VolumeRGB, andVertexRGB__init__signatures — unsupported keyword arguments now raiseTypeErrorinstead of being silently swallowedTest plan
test_download_subject)VertexRGBwithshared_rangeVertexRGBwith custom channel colorsTypeErroron unknown kwargs (bothVolumeRGBandVertexRGB)VolumeRGBshared_rangeand custom colorsCloses #579