Branch and html feature, bugfixes and improvements#9
Open
Dronakurl wants to merge 1 commit intogaborvecsei:mainfrom
Open
Branch and html feature, bugfixes and improvements#9Dronakurl wants to merge 1 commit intogaborvecsei:mainfrom
Dronakurl wants to merge 1 commit intogaborvecsei:mainfrom
Conversation
Use stylua format, replace vim script, data folder - stylua formatter changed a bit of code. The config is included - Some autocommand groups where defined in vim script. Converted to lua, for better debugging - Fixed all diagnostic messages with lua language server - moved the json file from .config to .local folder. Some people want .config to just be their settings (e.g. to include in their dotfiles). A log file should be placed elsewhere. I will make it configurable later - added a configuration with optional variables Configuration was previously handled with global variables. It is better to define a configuration that is optional - Add configuration option for json file path - Added the branch tracking - No aggregation yet gaborvecsei#7 - fixed wrong port in the telemetry endpoint - Better error handling telemetry, select aggregation The error handling for plenary.curl did not work, because it is an async call. plenary.curl documentation is not easy, but I found this nvim-lua/plenary.nvim#471 and included on_error to handle possible errors - When the user forgets the aggregation key, a selection is called. As it is vim.ui.select, it should be with the picker of choice - plenary test for config - html file generation using chart.js - doc file
Owner
|
@Dronakurl thank you very much for the PR! I'll try to review it in the following week - but this is a huge one so it'll take a bit of time. If you can see any features that could be in a separate PR, then it would help if you could separate them. |
Author
|
OK, I will see to it. I am on some other project right now, though. The html file generation could be separated, I think.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use stylua format, replace vim script, data folder