Version 2.1 with some changes in UI and functionality #1
Open
koljakt8 wants to merge 1 commit intofynn3003:mainfrom
Open
Version 2.1 with some changes in UI and functionality #1koljakt8 wants to merge 1 commit intofynn3003:mainfrom
koljakt8 wants to merge 1 commit intofynn3003:mainfrom
Conversation
fynn3003
reviewed
Jun 5, 2025
Owner
There was a problem hiding this comment.
naming of file (app(1.0).py) not according to PEP 8 (check: https://peps.python.org/pep-0008/)
fynn3003
reviewed
Jun 5, 2025
| # Only process if both origin and destination are present | ||
| if pd.notnull(row.get('origin', None)) and pd.notnull(row.get('destination', None)) and row['origin'] and row['destination']: | ||
| # Try to find airport by ICAO or IATA code | ||
| def find_airport(code): |
Owner
There was a problem hiding this comment.
Function defined in if condition, should not be like this. Either define function on Top or define in helper file!
| aircraft_counts = df['Aircraft'].value_counts() | ||
| airline_counts = df['Airline'].value_counts() | ||
|
|
||
| def render_stat_blocks(title, counts, color="#4F8BF9", label="Flights"): |
Owner
There was a problem hiding this comment.
Function defined in if condition, should not be like this. Either define function on Top or define in helper file!
| st.write("Add a new flight:") | ||
| airline = st.text_input("Airline", placeholder="Lufthansa") | ||
| aircraft = st.text_input("Aircraft", placeholder="B747-8i") | ||
| registration = st.text_input("Registration", placeholder="D-EEGL") |
Owner
There was a problem hiding this comment.
We should put the personal_flight_data.csv in .gitignore file!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New features have been added to allow an even deeper look in to one's flight data analysis.
Some bug fixes have been made, for example where NULL entries in the data would disrupt processing of said data.
Some changes to the UI were also done, going along with the new features.