-
Notifications
You must be signed in to change notification settings - Fork 3
Display a warning on mobile devices #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@fulopkovacs has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 12 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThis PR adds mobile device detection and routing. A server-side helper inspects the request user-agent in the index route's beforeLoad hook and conditionally redirects mobile clients to a new Changes
Sequence DiagramsequenceDiagram
actor Client
participant Server
participant Router
participant Mobile as Mobile Route
participant HomeIntro
Client->>Server: Request to /
Server->>Server: getIsMobile() checks user-agent
alt Mobile Device Detected
Server->>Router: redirect to /mobile
Router->>Mobile: load /mobile route
Mobile->>HomeIntro: render with isMobile=true
HomeIntro->>Client: show mobile warning & disabled button
else Desktop Device
Server->>Router: redirect to /projects
Router->>Client: load /projects route
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c5911f0 to
ad1c73b
Compare
🚀 Preview DeploymentStatus: ✅ Ready! Preview URL: Open Preview Commit: Built and deployed successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/components/HomeIntro.tsxsrc/routeTree.gen.tssrc/routes/index.tsxsrc/routes/mobile.tsx
🧰 Additional context used
📓 Path-based instructions (3)
src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Always ensure no formatting/linting issues exist in code - use
pnpm check --fixto automatically fix issues
Files:
src/components/HomeIntro.tsxsrc/routes/mobile.tsxsrc/routeTree.gen.tssrc/routes/index.tsx
**/*.{tsx,ts}
📄 CodeRabbit inference engine (AGENTS.md)
Prefer functions over arrow functions for React components
Files:
src/components/HomeIntro.tsxsrc/routes/mobile.tsxsrc/routeTree.gen.tssrc/routes/index.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Prefer
typeoverinterfacefor type definitions
Files:
src/components/HomeIntro.tsxsrc/routes/mobile.tsxsrc/routeTree.gen.tssrc/routes/index.tsx
🧠 Learnings (3)
📚 Learning: 2025-12-24T15:25:07.106Z
Learnt from: fulopkovacs
Repo: fulopkovacs/trytanstackdb.com PR: 22
File: src/components/TodoBoards.tsx:63-81
Timestamp: 2025-12-24T15:25:07.106Z
Learning: In Tailwind CSS v4, prefer canonical classes using bg-linear-to-* (e.g., bg-linear-to-b, bg-linear-to-t, bg-linear-to-r) over the older bg-gradient-to-* syntax. This aligns with Tailwind LSP's suggestCanonicalClasses rule. Apply across TSX files (e.g., src/components/*.tsx); replace occurrences of bg-gradient-to-* with the corresponding bg-linear-to-* equivalents and verify gradients visually.
Applied to files:
src/components/HomeIntro.tsxsrc/routes/mobile.tsxsrc/routes/index.tsx
📚 Learning: 2025-12-28T23:34:13.416Z
Learnt from: fulopkovacs
Repo: fulopkovacs/trytanstackdb.com PR: 32
File: src/components/HomeIntro.tsx:16-25
Timestamp: 2025-12-28T23:34:13.416Z
Learning: In Motion (motion/react), when configuring variant transitions, use delayChildren: stagger(x) to create per-child delays (e.g., delayChildren: stagger(0.2)). This is different from the older API that used a separate staggerChildren property. Apply this guidance to TSX files that declare motion variants (e.g., in src/components/**/*.tsx) and verify that stagger is imported from framer-motion. Ensure transitions reflect the intended stagger timing and that no conflicting delay values override the staggered effect.
Applied to files:
src/components/HomeIntro.tsxsrc/routes/mobile.tsxsrc/routes/index.tsx
📚 Learning: 2025-12-29T13:20:08.388Z
Learnt from: CR
Repo: fulopkovacs/trytanstackdb.com PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-29T13:20:08.388Z
Learning: Applies to src/route/__root.tsx : The root route is located at `src/route/__root.tsx` in this TanStack Start project
Applied to files:
src/routes/mobile.tsxsrc/routeTree.gen.tssrc/routes/index.tsx
🧬 Code graph analysis (3)
src/components/HomeIntro.tsx (4)
src/components/ui/card.tsx (2)
CardContent(91-91)CardFooter(87-87)src/components/ui/button.tsx (1)
Button(63-63)src/components/ui/sidebar.tsx (1)
isMobile(98-100)src/hooks/use-mobile.ts (1)
setIsMobile(12-14)
src/routes/mobile.tsx (2)
src/routes/index.tsx (1)
Route(12-26)src/components/HomeIntro.tsx (1)
HomeIntro(63-185)
src/routes/index.tsx (1)
src/routes/mobile.tsx (1)
Route(4-6)
🔇 Additional comments (5)
src/components/HomeIntro.tsx (3)
66-66: LGTM! Clean prop addition.The
isMobileprop with an optional default value is well-structured and integrates cleanly with the existing props.Also applies to: 70-70
127-127: Good centering adjustment.Adding
justify-centerensures the feature cards are centered when they wrap to a single column, improving the mobile layout.
148-153: Clear mobile UX with appropriate guardrails.The warning message clearly communicates the limitation, and disabling the button prevents mobile users from encountering a broken experience.
Also applies to: 159-159
src/routes/index.tsx (1)
5-10: Server function implementation looks correct.The user-agent detection logic is straightforward and covers common mobile devices.
src/routes/mobile.tsx (1)
8-14: LGTM! Clean mobile route implementation.The route correctly renders
HomeIntrowith the mobile configuration, providing a dedicated landing page for mobile users.
Summary by CodeRabbit
New Features
UI/UX Improvements
✏️ Tip: You can customize this high-level summary in your review settings.