fix(build): include Quota project in Debug solution builds#1297
Merged
Conversation
PR #1296 registered Quota.csproj in FSH.Starter.slnx but with <Build Solution="Debug|*" Project="false" />, which excludes the project from Debug solution builds. MSBuild drops ProjectReferences to projects disabled in the active solution configuration, so a plain 'dotnet build src/FSH.Starter.slnx' (Debug) compiled Storage and Web without the FSH.Framework.Quota reference and failed with CS0234/CS0246. CI stayed green because it builds Release, where the exclusion did not apply. Remove the exclusion so Quota builds in every configuration. Also revert the package-lock.json churn from the same PR (peer flags injected by a different npm version, no package.json change) so a plain 'npm install' no longer dirties the working tree. Fixes the remaining build failure reported in #1291. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1296 added
Quota.csprojtoFSH.Starter.slnx, but with a Debug build exclusion:In solution builds, MSBuild removes
ProjectReferences to projects that are disabled in the active solution configuration. So a plaindotnet build src/FSH.Starter.slnx(Debug by default) — or F5 in Visual Studio — compiledStorageandWebwithout theFSH.Framework.Quotareference and failed with the exact errors reported in #1291:Backend CI stayed green because it builds Release, where the exclusion did not apply.
Fix
Remove the build exclusion so Quota builds in every solution configuration:
Also reverts the
package-lock.jsonchurn from the same PR ("peer": trueflags injected by a different npm version, with no correspondingpackage.jsonchange) so a plainnpm installno longer dirties the working tree.Verification
dotnet build src/FSH.Starter.slnx -c Debug— 0 errors (failed with the 5 errors above before this change)dotnet build src/FSH.Starter.slnx -c Release— 0 errorsnpm installare byte-identical to the pre-fix(solution): register missing Quota project in FSH.Starter.slnx (resolves NU1105) #1296 stateFixes the remaining build failure in #1291.
🤖 Generated with Claude Code