Skip to content

fix(build): include Quota project in Debug solution builds#1297

Merged
iammukeshm merged 1 commit into
mainfrom
fix/quota-debug-solution-build
Jun 11, 2026
Merged

fix(build): include Quota project in Debug solution builds#1297
iammukeshm merged 1 commit into
mainfrom
fix/quota-debug-solution-build

Conversation

@iammukeshm

Copy link
Copy Markdown
Member

Problem

#1296 added Quota.csproj to FSH.Starter.slnx, but with a Debug build exclusion:

<Project Path="BuildingBlocks/Quota/Quota.csproj">
  <Build Solution="Debug|*" Project="false" />
</Project>

In solution builds, MSBuild removes ProjectReferences to projects that are disabled in the active solution configuration. So a plain dotnet build src/FSH.Starter.slnx (Debug by default) — or F5 in Visual Studio — compiled Storage and Web without the FSH.Framework.Quota reference and failed with the exact errors reported in #1291:

Storage\Extensions.cs(5,21): error CS0234: The type or namespace name 'Quota' does not exist in the namespace 'FSH.Framework'
Storage\QuotaMeteredStorageService.cs(24,22): error CS0246: The type or namespace name 'IQuotaService' could not be found
Web\Extensions.cs(5,21): error CS0234: The type or namespace name 'Quota' does not exist in the namespace 'FSH.Framework'

Backend CI stayed green because it builds Release, where the exclusion did not apply.

Fix

Remove the build exclusion so Quota builds in every solution configuration:

<Project Path="BuildingBlocks/Quota/Quota.csproj" />

Also reverts the package-lock.json churn from the same PR ("peer": true flags injected by a different npm version, with no corresponding package.json change) so a plain npm install no longer dirties the working tree.

Verification

Fixes the remaining build failure in #1291.

🤖 Generated with Claude Code

PR #1296 registered Quota.csproj in FSH.Starter.slnx but with
<Build Solution="Debug|*" Project="false" />, which excludes the
project from Debug solution builds. MSBuild drops ProjectReferences
to projects disabled in the active solution configuration, so a plain
'dotnet build src/FSH.Starter.slnx' (Debug) compiled Storage and Web
without the FSH.Framework.Quota reference and failed with CS0234/CS0246.
CI stayed green because it builds Release, where the exclusion did not
apply. Remove the exclusion so Quota builds in every configuration.

Also revert the package-lock.json churn from the same PR (peer flags
injected by a different npm version, no package.json change) so a
plain 'npm install' no longer dirties the working tree.

Fixes the remaining build failure reported in #1291.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@iammukeshm iammukeshm mentioned this pull request Jun 11, 2026
@iammukeshm iammukeshm merged commit 13cda12 into main Jun 11, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant