Skip to content

Conversation

@ap--
Copy link
Collaborator

@ap-- ap-- commented Nov 30, 2025

Xfail tests that rely on a network connection if not available.

@ap-- ap-- self-assigned this Nov 30, 2025
@ap-- ap-- merged commit 0a1f78c into fsspec:main Nov 30, 2025
27 checks passed
)


def has_internet_connection():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this supposed to be used somewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #505

pytestmark = pytest.mark.skip


def xfail_on_hf_service_unavailable(func):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is unused; should it be decorating test_hfpath instead of the changes in that test?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #505

ap-- added a commit to ap--/universal_pathlib that referenced this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants