sshfs: make _finalize method static to allow garbage collection#62
Merged
skshetry merged 1 commit intofsspec:mainfrom Oct 28, 2025
Merged
sshfs: make _finalize method static to allow garbage collection#62skshetry merged 1 commit intofsspec:mainfrom
skshetry merged 1 commit intofsspec:mainfrom
Conversation
Using a bound method with weakref.finalize was keeping a reference to the `SSHFileSystem` instance, preventing it from being garbage collected. See note at the end of the Python documentation for [`weakref.finalize`][1]: > Note: It is important to ensure that func, args and kwargs do not own any references to obj, > either directly or indirectly, since otherwise obj will never be garbage collected. > In particular, func should not be a bound method of obj. [1]: https://docs.python.org/3/library/weakref.html#weakref.finalize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a bound method with weakref.finalize was keeping a reference to the
SSHFileSysteminstance, preventing it from being garbage collected.sshfs/sshfs/spec.py
Lines 73 to 75 in e371f39
sshfs/sshfs/spec.py
Line 98 in 32addf6
See note at the end of the Python documentation for
weakref.finalize: