Solution to https://github.com/fsspec/sshfs/issues/54#57
Closed
99-NinetyNine wants to merge 12 commits intofsspec:mainfrom
Closed
Solution to https://github.com/fsspec/sshfs/issues/54#5799-NinetyNine wants to merge 12 commits intofsspec:mainfrom
99-NinetyNine wants to merge 12 commits intofsspec:mainfrom
Conversation
skshetry
reviewed
Feb 6, 2025
| install_requires = | ||
| fsspec>=2021.8.1 | ||
| asyncssh>=2.11.0,<3 | ||
| asyncssh==2.19.0 |
Collaborator
There was a problem hiding this comment.
Let's keep it this way:
Suggested change
| asyncssh==2.19.0 | |
| asyncssh>=2.11.0,<3 |
skshetry
reviewed
Feb 6, 2025
|
|
||
| if local_user is None: | ||
| with suppress(KeyError): | ||
| with suppress(OSError): # Use OSError as getuser() might raise this. |
Collaborator
There was a problem hiding this comment.
Let's keep KeyError too. I see that it raises OSError now in 3.13, but that is not true for older versions.
Suggested change
| with suppress(OSError): # Use OSError as getuser() might raise this. | |
| with suppress(OSError): # Use OSError as getuser() might raise this. |
skshetry
reviewed
Feb 6, 2025
| return SSHClientConfig.load( | ||
| # Check asyncssh version | ||
| version = tuple(map(int, asyncssh.__version__.split("."))) | ||
| if version <= (2, 18, 0): # Compare version properly |
Collaborator
There was a problem hiding this comment.
Suggested change
| if version <= (2, 18, 0): # Compare version properly | |
| if version < (2, 19, 0): # Compare version properly |
skshetry
reviewed
Feb 6, 2025
Comment on lines
+40
to
+41
| canonical, # Use correct parameter | ||
| final, # Use correct parameter |
Collaborator
There was a problem hiding this comment.
All these comments are unnecessary.
skshetry
reviewed
Feb 6, 2025
| def parse_config( | ||
| *, host, user=(), port=(), local_user=None, config_files=None | ||
| ): | ||
| def parse_config(*, host, user=(), port=(), local_user=None, config_files=None): |
Collaborator
There was a problem hiding this comment.
I'd also add a warning that the function is deprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.