Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
@efiop Would you mind reviewing this PR? |
|
Hey, @ttomasz , thanks for the PR! Please see some suggestions above. |
|
@ttomasz a gentle reminder :) or can we close this PR? |
|
Sorry, was quite busy past few months 😅 I should be able to finish this up in June. |
2a39ec4 to
0a8a32d
Compare
|
Changed popping kwargs to separate parameter for stuff to pass to underlying library. |
|
Sorry for the mess with the commits. Do you want me to revert client_args/connect_args to being kwargs instead of parameter? Or is the current state ok? |
|
Can I ask for this PR to get revived? I too need to pass options to I need to override the default |
Fixes #39