[repo-assist] fix: skip empty Cookie header when no cookie parameters are present#454
Merged
sergey-tihon merged 3 commits intoMay 27, 2026
Conversation
When an API operation has no cookie parameters (the common case),
OperationCompiler was always prepending ("Cookie", "") to the headers
list. fillHeaders only filters null values — not empty strings — so
the empty Cookie: header was sent with every request.
Fix: only prepend the Cookie header when cookieHeader is non-empty.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6 tasks
…-da1d142b1568bd53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
When an API operation has no cookie parameters (the common case),
OperationCompilerwas always prepending("Cookie", "")to the headers list.fillHeadersonly filtersnullvalues, not empty strings, so an emptyCookie:header was sent with every HTTP request.Root cause
The cookie header construction unconditionally built:
even when
cookieHeaderwas""(no cookies declared on the operation).Fix
Only prepend the
Cookieheader when the constructed cookie string is non-empty:This means:
Cookie:header sentImpact
Cookie:header from every non-cookie API callTest Status
All 465 unit tests pass. Format check passes (
dotnet fantomas --check).Add this agentic workflows to your repo
To install this agentic workflow, run