[repo-assist] remove: Dockerfile and mybinder badge/documentation#1204
[repo-assist] remove: Dockerfile and mybinder badge/documentation#1204github-actions[bot] wants to merge 5 commits into
Conversation
Remove the docs/Dockerfile (used for mybinder.org Binder integration) and all mybinder badge links from the six documentation .fsx pages. Also remove the mybinder documentation section from content.fsx and the mybinder recommendation from upgrade.md. The Binder integration relied on a deprecated .NET 7 SDK image and a deprecated Microsoft.dotnet-interactive version; mybinder.org support is discontinued per maintainer decision. Closes #1178 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
I’d suggest we also remove the “run this in ipynb links” while we’re at it given .net interactive is deprecated and there’s currently no replacement. It’s easy enough to resurrect the links later if the .net notebook situation improves via community efforts (see my link in the linked issue this pr references). The links have format like |
|
/repo-assist fix failing CI |
|
✓ Repo Assist completed successfully, see workflow run. |
The docs/Dockerfile was deleted as part of the mybinder removal, but the NuGet pack content reference in fsdocs-tool.fsproj was not updated, causing NU5019 build failure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Commit pushed:
|
|
🤖 This is an automated response from Repo Assist. Fixed! The CI failure was caused by
|
2 participants
🤖 This PR was created by Repo Assist, an automated AI assistant, at the request of
@dsyme.Closes #1178
Summary
Removes the mybinder.org Binder integration from this repository, as requested by the maintainer.
Changes
docs/Dockerfiledocs/img/badge-binder.svgdocs/content.fsxdocs/codeformat.fsxdocs/markdown.fsxdocs/apidocs.fsxdocs/evaluation.fsxdocs/literate.fsxdocs/upgrade.mdRELEASE_NOTES.md[Unreleased] ### RemovedRationale
The Binder integration relied on:
mcr.microsoft.com/dotnet/sdk:7.0, EOL May 2024)Microsoft.dotnet-interactiveversion (1.0.410202)Per the maintainer discussion in #1178, the Dockerfile is only used for mybinder.org (the "run in Binder" badge on docs pages), not in CI. The decision was made to remove it cleanly rather than update to a new (also potentially deprecated) version.
Test Status
dotnet fantomas docs/*.fsx --check— formatting verified, no changes needed