[Repo Assist] fix: correct JSON block comment parser to handle * and / inside comments#1710
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
Conversation
The while-loop condition used '&&' (De Morgan AND) which caused the parser to exit too early whenever a bare '*' or '/' appeared inside a /* ... */ comment body. For example: /* path/to/file */ — the lone '/' stopped the scan /* a * b */ — the bare '*' stopped the scan The correct guard is '||': keep scanning until we see BOTH '*' AND '/' in sequence. Adds three regression tests covering the previously-failing patterns. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist, an AI assistant for this repository.
Summary
Fixes a bug in the JSON
/* ... */comment parser where a*or/character appearing inside the comment body caused premature loop termination and a subsequentensurefailure (exception).Root Cause
The while-loop condition in
JsonParser.skipCommentused&&instead of||:By De Morgan's law,
NOT A AND NOT Bis equivalent toNOT (A OR B), meaning the loop exited the moment either character matched — not when both*/appeared in sequence. The fix is:Failing Examples (before fix)
Both threw
System.Exception: Invalid JSON starting at character ...before this fix.Changes
src/FSharp.Data.Json.Core/JsonValue.fs&&→ `tests/FSharp.Data.Core.Tests/JsonValue.fsRELEASE_NOTES.mdTest Status