Skip to content

[Repo Assist] fix: correct SqlMetaData constructor selection for datetime2/datetimeoffset/time TVP columns #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smoothdeveloper merged 2 commits into from
Mar 13, 2026
Merged

[Repo Assist] fix: correct SqlMetaData constructor selection for datetime2/datetimeoffset/time TVP columns #464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae194e3
fix: correct SqlMetaData constructor selection for datetime2/datetime…
github-actions[bot] Mar 13, 2026
c69b139
ci: trigger checks
github-actions[bot] Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/SqlClient.DesignTime/DesignTime.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,11 +542,15 @@ type DesignTime private() =
let precision = byte p.Precision
let scale = byte p.Scale
if typeInfo.IsFixedLength then
match name, dbType with
| "datetime2" , SqlDbType.DateTime2
| "datetimeoffset", SqlDbType.DateTimeOffset
| "time" , SqlDbType.Time ->
match dbType with
| SqlDbType.DateTime2
| SqlDbType.DateTimeOffset
| SqlDbType.Time ->
// https://github.com/fsprojects/FSharp.Data.SqlClient/issues/393
// These types use (name, dbType, precision, scale) but precision must be 0,
// not the value from sys.columns (which is 10 for datetimeoffset etc.).
// The previous match on `name` was incorrect — it compared the column name
// (e.g. "CreatedAt") to the type name, so the fix never fired.
<@@ SqlMetaData(name, dbType, 0uy, scale) @@>
| _ ->
// https://github.com/fsprojects/FSharp.Data.SqlClient/issues/345
Expand Down
Loading