Skip to content

[Repo Assist] chore: fix ToCommantText typo, simplify getSqlDbType, fix TempTableLoader.Close #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[Repo Assist] chore: fix ToCommantText typo, simplify getSqlDbType, fix TempTableLoader.Close #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43190c8
chore: fix ToCommantText typo, simplify getSqlDbType, fix TempTableLo…
github-actions[bot] Mar 11, 2026
2c67ffc
ci: trigger checks
github-actions[bot] Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SqlClient.DesignTime/SqlClientExtensions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ type internal Routine = {

member this.IsStoredProc = this.Type = StoredProcedure

member this.ToCommantText(parameters: Parameter list) =
member this.ToCommandText(parameters: Parameter list) =
let twoPartNameIdentifier = sprintf "%s.%s" <|| this.TwoPartName
match this.Type with
| StoredProcedure -> twoPartNameIdentifier
Expand Down
2 changes: 1 addition & 1 deletion src/SqlClient.DesignTime/SqlClientProvider.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ type SqlProgrammabilityProvider(config : TypeProviderConfig) as this =
use __ = conn.UseLocally()
let parameters = conn.GetParameters( routine, isSqlAzure, useReturnValue)

let commandText = routine.ToCommantText(parameters)
let commandText = routine.ToCommandText(parameters)
let outputColumns = DesignTime.GetOutputColumns(conn, commandText, parameters, routine.IsStoredProc)
let rank = if routine.Type = ScalarValuedFunction then ResultRank.ScalarValue else ResultRank.Sequence

Expand Down
7 changes: 2 additions & 5 deletions src/SqlClient/ISqlCommand.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,8 @@ type ``ISqlCommand Implementation``(cfg: DesignTimeConfig, connection: Connectio
else
sprintf "%s %A" p.ParameterName p.SqlDbType

// helper map to resolve each parameter's target type
let getSqlDbType =
let lookup = Map.ofSeq <| Seq.zip (parameters |> Seq.map (fun (name, value) -> name))
(cmd.Parameters |> Seq.cast<SqlParameter> |> Seq.map (fun p -> p.SqlDbType))
fun name -> Map.find name lookup
// helper to resolve each parameter's target type
let getSqlDbType (name: string) = cmd.Parameters.[name].SqlDbType

seq {

Expand Down
59 changes: 30 additions & 29 deletions src/SqlClient/Shared.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,7 @@ type [<DataContract;CLIMutable>] Parameter = {
#endif
type TempTableLoader(fieldCount, items: obj seq) =
let enumerator = items.GetEnumerator()
let mutable isClosed = false

interface IDataReader with
member this.FieldCount: int = fieldCount
Expand All @@ -197,35 +198,35 @@ type TempTableLoader(fieldCount, items: obj seq) =
row.[i]
member this.Dispose(): unit = ()

member __.Close(): unit = invalidOp "NotImplementedException"
member __.Depth: int = invalidOp "NotImplementedException"
member __.GetBoolean(_: int): bool = invalidOp "NotImplementedException"
member __.GetByte(_ : int): byte = invalidOp "NotImplementedException"
member __.GetBytes(_ : int, _ : int64, _ : byte [], _ : int, _ : int): int64 = invalidOp "NotImplementedException"
member __.GetChar(_ : int): char = invalidOp "NotImplementedException"
member __.GetChars(_ : int, _ : int64, _ : char [], _ : int, _ : int): int64 = invalidOp "NotImplementedException"
member __.GetData(_ : int): IDataReader = invalidOp "NotImplementedException"
member __.GetDataTypeName(_ : int): string = invalidOp "NotImplementedException"
member __.GetDateTime(_ : int): System.DateTime = invalidOp "NotImplementedException"
member __.GetDecimal(_ : int): decimal = invalidOp "NotImplementedException"
member __.GetDouble(_ : int): float = invalidOp "NotImplementedException"
member __.GetFieldType(_ : int): System.Type = invalidOp "NotImplementedException"
member __.GetFloat(_ : int): float32 = invalidOp "NotImplementedException"
member __.GetGuid(_ : int): System.Guid = invalidOp "NotImplementedException"
member __.GetInt16(_ : int): int16 = invalidOp "NotImplementedException"
member __.GetInt32(_ : int): int = invalidOp "NotImplementedException"
member __.GetInt64(_ : int): int64 = invalidOp "NotImplementedException"
member __.GetName(_ : int): string = invalidOp "NotImplementedException"
member __.GetOrdinal(_ : string): int = invalidOp "NotImplementedException"
member __.GetSchemaTable(): DataTable = invalidOp "NotImplementedException"
member __.GetString(_ : int): string = invalidOp "NotImplementedException"
member __.GetValues(_ : obj []): int = invalidOp "NotImplementedException"
member __.IsClosed: bool = invalidOp "NotImplementedException"
member __.IsDBNull(_ : int): bool = invalidOp "NotImplementedException"
member __.Item with get (_ : int): obj = invalidOp "NotImplementedException"
member __.Item with get (_ : string): obj = invalidOp "NotImplementedException"
member __.NextResult(): bool = invalidOp "NotImplementedException"
member __.RecordsAffected: int = invalidOp "NotImplementedException"
member __.Close(): unit = isClosed <- true
member __.Depth: int = raise (NotImplementedException())
member __.GetBoolean(_: int): bool = raise (NotImplementedException())
member __.GetByte(_ : int): byte = raise (NotImplementedException())
member __.GetBytes(_ : int, _ : int64, _ : byte [], _ : int, _ : int): int64 = raise (NotImplementedException())
member __.GetChar(_ : int): char = raise (NotImplementedException())
member __.GetChars(_ : int, _ : int64, _ : char [], _ : int, _ : int): int64 = raise (NotImplementedException())
member __.GetData(_ : int): IDataReader = raise (NotImplementedException())
member __.GetDataTypeName(_ : int): string = raise (NotImplementedException())
member __.GetDateTime(_ : int): System.DateTime = raise (NotImplementedException())
member __.GetDecimal(_ : int): decimal = raise (NotImplementedException())
member __.GetDouble(_ : int): float = raise (NotImplementedException())
member __.GetFieldType(_ : int): System.Type = raise (NotImplementedException())
member __.GetFloat(_ : int): float32 = raise (NotImplementedException())
member __.GetGuid(_ : int): System.Guid = raise (NotImplementedException())
member __.GetInt16(_ : int): int16 = raise (NotImplementedException())
member __.GetInt32(_ : int): int = raise (NotImplementedException())
member __.GetInt64(_ : int): int64 = raise (NotImplementedException())
member __.GetName(_ : int): string = raise (NotImplementedException())
member __.GetOrdinal(_ : string): int = raise (NotImplementedException())
member __.GetSchemaTable(): DataTable = raise (NotImplementedException())
member __.GetString(_ : int): string = raise (NotImplementedException())
member __.GetValues(_ : obj []): int = raise (NotImplementedException())
member __.IsClosed: bool = isClosed
member __.IsDBNull(_ : int): bool = raise (NotImplementedException())
member __.Item with get (_ : int): obj = raise (NotImplementedException())
member __.Item with get (_ : string): obj = raise (NotImplementedException())
member __.NextResult(): bool = raise (NotImplementedException())
member __.RecordsAffected: int = raise (NotImplementedException())

module RuntimeInternals =

Expand Down
Loading