Fix TimeSpan.FromMilliseconds ambiguity with .NET 10#547
Merged
xperiandri merged 1 commit intofsprojects:devfrom Jan 23, 2026
Merged
Fix TimeSpan.FromMilliseconds ambiguity with .NET 10#547xperiandri merged 1 commit intofsprojects:devfrom
TimeSpan.FromMilliseconds ambiguity with .NET 10#547xperiandri merged 1 commit intofsprojects:devfrom
Conversation
xperiandri
approved these changes
Jan 23, 2026
TimeSpan.FromMilliseconds ambiguity with .NET 10
Collaborator
|
Thank you for the contribution! |
Contributor
Author
No, I'm good. I'm running on my own fork of the repo with some extra stuff added. Btw, thanks for the time and effort you're investing in maintaining this library. It's really amazing. |
xperiandri
pushed a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build for .NET 10, I'm getting
The reason is that in .NET 9.0 TimeSpan.FromMilliseconds had 2 overloads:
In .NET 10.0 there are now 3 overloads:
... and F# doesn't know whether it should convert the provided int32 into an int64 or double.
This patch defaults to double which makes it compile with both .NET 9 and 10.