Enhancement: Create the imposter folder when the mock server is start…#144
Open
Gauravms2143 wants to merge 1 commit intofriendsofgo:mainfrom
Open
Enhancement: Create the imposter folder when the mock server is start…#144Gauravms2143 wants to merge 1 commit intofriendsofgo:mainfrom
Gauravms2143 wants to merge 1 commit intofriendsofgo:mainfrom
Conversation
Member
|
Hey @Gauravms2143, First of all thanks for your contribution, it's really nice to see new faces contributing to the project. However, I'd love to understand what's the goal of this pull request and which are the pains it's trying to solve, before digging into the code details. Could you extend the description with some additional context? Here's some initial thoughts I have:
Which makes me think that:
cc/ @aperezg any additional thoughts? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we launch the mock server:
Earlier Behaviour:
New approach:
Test Case:
I removed the first test case from server_test.go.
If we use second approach there is no need to check if the imposters folder exists or not.