Skip to content

Refine sticky notes#465

Merged
stijnpotters1 merged 11 commits into
masterfrom
fix/refine-sticky-notes
May 12, 2026
Merged

Refine sticky notes#465
stijnpotters1 merged 11 commits into
masterfrom
fix/refine-sticky-notes

Conversation

@stijnpotters1
Copy link
Copy Markdown
Contributor

@stijnpotters1 stijnpotters1 commented May 4, 2026 •
edited
Loading

image image image

@stijnpotters1 stijnpotters1 linked an issue May 4, 2026 that may be closed by this pull request
Note improvements #451
Closed
@philipsens
Copy link
Copy Markdown
Member

philipsens commented May 5, 2026 •
edited
Loading

We spoke about implementing the missing features.

Also. If you're working on it, is there any way to make the border look a bit nicer
(or remove it)?

@stijnpotters1
Copy link
Copy Markdown
Contributor Author

stijnpotters1 commented May 5, 2026

We spoke about implementing the missing features.

Also. If you're working on it, is there any way to make the border look a bit nicer (or remove it)?

The node can be seen in the frank element context menu now and when the note it attached it follows the attached node if it moved in the canvas!

@stijnpotters1 stijnpotters1 self-assigned this May 5, 2026
@philipsens
Copy link
Copy Markdown
Member

philipsens commented May 5, 2026 •
edited
Loading

Very cool!

Matthbo
Matthbo reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to not shorten variables to just one character

Comment thread src/main/frontend/app/routes/studio/canvas/flow.tsx
Comment thread src/main/frontend/app/routes/studio/xml-to-json-parser.ts Outdated
@stijnpotters1
Copy link
Copy Markdown
Contributor Author

stijnpotters1 commented May 6, 2026

Don't forget to not shorten variables to just one character

Sorry, i will pay more attention to it in the future!

@stijnpotters1 stijnpotters1 requested a review from Matthbo May 6, 2026 11:24
stijnpotters1 and others added 9 commits May 11, 2026 13:37
@stijnpotters1
Enhance sticky note functionality with color, collapse, and attachmen…
5ba2635 
…t features
@stijnpotters1
Enhance flow data saving and improve sticky note attachment handling
e99ec95
@stijnpotters1
Enhance flow data saving and improve sticky note attachment handling
b10a6cc
@stijnpotters1
Enhance sticky note attachment logic and implement snapping to neares…
fcd1d0d 
…t nodes
@stijnpotters1
Refactor sticky note context labels for improved consistency and upda…
78980ad 
…te attachment logic
@stijnpotters1 @Matthbo
Update src/main/frontend/app/routes/studio/xml-to-json-parser.ts
d5039e9 
Co-authored-by: Vivy <4380412+Matthbo@users.noreply.github.com>
Signed-off-by: Stijn Potters <stijn.potters1@gmail.com>
@stijnpotters1
Refactor flow attribute handling in XML to JSON parser for improved c…
1ba7bd4 
…onsistency
@stijnpotters1
Refactor numeric attribute handling in XML to JSON parser for improve…
b4bb9e7 
…d clarity and consistency
@stijnpotters1
Refactor variable names in sticky note context for improved clarity a…
62e0480 
…nd consistency
@stijnpotters1 stijnpotters1 force-pushed the fix/refine-sticky-notes branch from b6c2961 to 62e0480 Compare May 11, 2026 12:34
philipsens
philipsens reviewed May 11, 2026
View reviewed changes
Comment thread src/main/frontend/app/routes/studio/canvas/nodetypes/sticky-note.tsx
Matthbo
Matthbo reviewed May 11, 2026
View reviewed changes
Comment thread src/main/frontend/app/routes/studio/canvas/flow.tsx Outdated
Matthbo
Matthbo requested changes May 11, 2026
View reviewed changes
Comment thread src/main/frontend/app/routes/studio/context/sticky-note-context.tsx Outdated
Comment thread src/main/frontend/app/routes/studio/studio.tsx Outdated
Comment thread src/main/frontend/app/routes/studio/xml-to-json-parser.ts Outdated
@stijnpotters1 stijnpotters1 requested a review from Matthbo May 11, 2026 15:32
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 11, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stijnpotters1 stijnpotters1 merged commit e4ca6e9 into master May 12, 2026
5 checks passed
@stijnpotters1 stijnpotters1 deleted the fix/refine-sticky-notes branch May 12, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matthbo Matthbo Matthbo approved these changes

@philipsens philipsens Awaiting requested review from philipsens

Assignees

@stijnpotters1 stijnpotters1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Note improvements

3 participants

@stijnpotters1 @philipsens @Matthbo