support ruby 3.4.0 style backtrace string#74
Merged
fractaledmind merged 4 commits intofractaledmind:mainfrom Jun 10, 2025
Merged
support ruby 3.4.0 style backtrace string#74fractaledmind merged 4 commits intofractaledmind:mainfrom
fractaledmind merged 4 commits intofractaledmind:mainfrom
Conversation
239ef08 to
aa7a1a8
Compare
Contributor
Author
|
passed on my repo https://github.com/kuboon/solid_errors/actions/runs/13322147541 |
|
For anyone waiting for this to be merged, as a quick hack you can put this into the ActiveSupport.on_load(:after_initialize) do
SolidErrors::BacktraceLine.send(:remove_const, :INPUT_FORMAT)
SolidErrors::BacktraceLine.const_set(:INPUT_FORMAT, %r{^((?:[a-zA-Z]:)?[^:]+):(\d+)(?::in [`']([^']+)')?$})
end |
fractaledmind
approved these changes
May 26, 2025
Contributor
Author
|
@fractaledmind Thank you for approving. Could you merge this? |
Owner
|
Live in v0.7.0 now. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ruby 3.4.0, backtrace string format has changed to use single quote instead of backtick.
ruby/ruby@25d74b9
https://bugs.ruby-lang.org/issues/16495