This repository was archived by the owner on Apr 21, 2026. It is now read-only.
Do not error if the source code is not verified#17
Closed
scrogson wants to merge 1 commit intofoundry-rs:mainfrom
Closed
Do not error if the source code is not verified#17scrogson wants to merge 1 commit intofoundry-rs:mainfrom
scrogson wants to merge 1 commit intofoundry-rs:mainfrom
Conversation
Member
|
If the source code is not verified, what would the object that |
Author
Here's an example with my changes: Metadata {
source_code: SourceCode(""),
abi: "Contract source code not verified",
contract_name: "",
compiler_version: "",
optimization_used: 0,
runs: 0,
constructor_arguments: Bytes(0x),
evm_version: "Default",
library: "",
license_type: "Unknown",
proxy: 1,
implementation: Some(0xa12dd5e3f3f1d932ecb2d6b7a3f22e1df5e3403c),
swarm_source: "",
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fetching the source code for a proxy contract, the source code is most likely not verified. In the current implementation, the code returns an error and makes it impossible to detect the implementation address in order to make the same request against that address.
This change makes it possible to proceed with the request even if the source code is not verified, and allow the caller to control the flow from there.
I could see a potentially different implementation where we return a different error that contains the address of the implementation contract if that is preferred.
Wdyt?