Fix(system_subprocess): save_completed_state passing stderr instead of stdin to callback

[Mahmood-Sinan]

Fixes incorrect argument mapping in process_callback inside save_completed_state subroutine where process%stderr was passed twice, causing stdin to be omitted. In one place process%stderr was being passed in place of process%stdin. This change correctly passes process%stdin.

[codecov]

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 68.81%. Comparing base (d30e087) to head (abb8ba4).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
test/system/test_subprocess.f90	96.42%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
+ Coverage   68.73%   68.81%   +0.07%     
==========================================
  Files         408      408              
  Lines       13697    13726      +29     
  Branches     1543     1552       +9     
==========================================
+ Hits         9415     9445      +30     
+ Misses       4282     4281       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[perazz]

Nice catch, thank you for fixing that @Mahmood-Sinan. Would it be possible to add a test routine that exercises using stdin with a process completion callback ?

[Mahmood-Sinan]

Nice catch, thank you for fixing that @Mahmood-Sinan. Would it be possible to add a test routine that exercises using stdin with a process completion callback ?

Thanks for reviewing. I have added the test for callback. I had to use a wrapper for payload because array of character strings were getting converted into a scalar variable in callback subroutine. Please take a look.

[jvdp1]

thank you @Mahmood-Sinan . Here are a few suggestions

[jvdp1]

could be the DT string_type of stdlib used?

[Mahmood-Sinan]

When I tried, the compiler gave me an error saying that

  193 |             type is (string_type)
      |                                 1
Error: The type-spec shall not specify a sequence derived type or a type with the BIND attribute in SELECT TYPE at (1) [F2003:C815]

I suppose we cannot do so, since string_type has sequence attribute.

[Mahmood-Sinan]

@jvdp1 Thanks for reviewing. I have made the changes.

[Mahmood-Sinan]

@jvdp1 please check.

[jvdp1]

Thank you @Mahmood-Sinan . LGTM.
Could you merge the master branch back to resolve the CI issue, please? Then it will be ready to be merged IMO.

[Mahmood-Sinan]

@jvdp1 I have merged rhe master branch. Please check.

[jvdp1]

thank you @Mahmood-Sinan . I'll merge it.