Skip to content

Exclude partners.json and publications.yaml from data artifact#748

Merged
richarddushime merged 1 commit intomasterfrom
fix/exclude-partners-from-artifact
Apr 15, 2026
Merged

Exclude partners.json and publications.yaml from data artifact#748
richarddushime merged 1 commit intomasterfrom
fix/exclude-partners-from-artifact

Conversation

@LukasWallrich
Copy link
Copy Markdown
Contributor

Summary

  • The data-processing workflow uploads the entire data/ directory as an artifact, which the deploy workflow then overlays onto the master checkout
  • This meant partners.json and publications.yaml were silently overwritten on every deploy with the version from the last data-processing run — so edits to these files on master wouldn't go live until data-processing ran again
  • Adds !data/partners.json and !data/publications.yaml exclusions to the artifact upload, so the master-branch versions of these hand-curated files are always used

Test plan

  • Trigger a data-processing run and verify partners.json/publications.yaml are absent from the artifact
  • Verify the deploy still succeeds and uses the master versions of those files

🤖 Generated with Claude Code

These are hand-curated static files that should always be taken from
the master branch checkout, not overwritten by the data-processing
artifact on each deploy.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@LukasWallrich LukasWallrich requested a review from a team as a code owner April 15, 2026 19:46
@github-actions
Copy link
Copy Markdown
Contributor

👍 All image files/references (if any) are in webp format, in line with our policy.

@github-actions
Copy link
Copy Markdown
Contributor

✅ Spell Check Passed

No spelling issues found when checking 1 changed file(s)! 🎉

@LukasWallrich
Copy link
Copy Markdown
Contributor Author

Staging Deployment Status

This PR has been successfully deployed to staging as part of an aggregated deployment.

Deployed at: 2026-04-15 19:50:27 UTC
Staging URL: https://staging.forrt.org

The staging site shows the combined state of all compatible open PRs.

Copy link
Copy Markdown
Contributor

@richarddushime richarddushime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@richarddushime richarddushime merged commit 4ac731e into master Apr 15, 2026
5 checks passed
@richarddushime richarddushime deleted the fix/exclude-partners-from-artifact branch April 15, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants