Skip to content

Comments

Copilot/make cluster page searchable#616

Open
LukasWallrich wants to merge 14 commits intomasterfrom
copilot/make-cluster-page-searchable
Open

Copilot/make cluster page searchable#616
LukasWallrich wants to merge 14 commits intomasterfrom
copilot/make-cluster-page-searchable

Conversation

@LukasWallrich
Copy link
Contributor

This is the start of an implementation of a search function. Currently, the results display is not great and the box does not close when trying to navigate it

@LukasWallrich LukasWallrich requested a review from a team as a code owner February 4, 2026 17:35
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

✅ Spell Check Passed

No spelling issues found in this PR! 🎉

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

👍 All image files/references (if any) are in webp format, in line with our policy.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

✅ Spell Check Passed

No spelling issues found in this PR! 🎉

@LukasWallrich
Copy link
Contributor Author

LukasWallrich commented Feb 4, 2026

Staging Deployment Status

This PR has been successfully deployed to staging as part of an aggregated deployment.

Deployed at: 2026-02-20 13:02:18 UTC
Staging URL: https://staging.forrt.org

The staging site shows the combined state of all compatible open PRs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

✅ Spell Check Passed

No spelling issues found in this PR! 🎉

@github-actions
Copy link
Contributor

✅ Spell Check Passed

No spelling issues found in this PR! 🎉

@LukasWallrich
Copy link
Contributor Author

@copilot this does not work - I cannot navigate to results as the box is far too big. Rethink the layout - maybe have the search as a collapsible section on the left?

Copy link
Contributor

Copilot AI commented Feb 18, 2026

@LukasWallrich I've opened a new pull request, #650, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions
Copy link
Contributor

✅ Spell Check Passed

No spelling issues found in this PR! 🎉

Copilot AI and others added 2 commits February 18, 2026 16:49
* Initial plan

* Redesign cluster search as collapsible left sidebar

Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>

* Fix code review feedback: use alert-info for no results and prevent layout shift

Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>
@github-actions
Copy link
Contributor

✅ Spell Check Passed

No spelling issues found in this PR! 🎉

1 similar comment
@github-actions
Copy link
Contributor

✅ Spell Check Passed

No spelling issues found in this PR! 🎉

@LukasWallrich
Copy link
Contributor Author

@copilot the closing button is behind the navbar, make sure it is visible. Also, when scrolling to a result, that result appears at the bottom of the window. Scroll so that it is at the top

Copy link
Contributor

Copilot AI commented Feb 18, 2026

@LukasWallrich I've opened a new pull request, #654, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2026

📝 Spell Check Results

Found 5 potential spelling issue(s) in this PR:

📄 content/glossary/english/open_material.md

Line Issue
16 Wit ==> With

📄 content/glossary/english/plan_s.md

Line Issue
4 commited ==> committed

📄 content/glossary/english/pro.md

Line Issue
4 publically ==> publicly

📄 content/glossary/english/research_protocol.md

Line Issue
4 publically ==> publicly

📄 content/glossary/english/type_i_error.md

Line Issue
4 occured ==> occurred

ℹ️ How to address these issues:

  1. Fix the typo: If it's a genuine typo, please correct it.
  2. Add to whitelist: If it's a valid word (e.g., a name, technical term), add it to .codespell-ignore.txt
  3. False positive: If this is a false positive, please report it in the PR comments.

🤖 This check was performed by codespell

* Initial plan

* Fix search panel visibility and scroll behavior

Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: LukasWallrich <60155545+LukasWallrich@users.noreply.github.com>
Co-authored-by: Lukas Wallrich <lukas.wallrich@gmail.com>
- Auto-hide panel when clicking search result
- Position panel below navbar to avoid hiding logo
- Reduce panel width to 70% on mobile devices
- Show only search icon on mobile toggle button
@richarddushime
Copy link
Contributor

@LukasWallrich i made a commit with the below improvements

  • Auto-hide panel when clicking search result
  • Position panel below navbar to avoid hiding logo
  • Reduce panel width to 70% on mobile devices
  • Show only search icon on mobile toggle button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants