fix: click outside click issue

[pandeymangg]

Fixes #13
This includes adding a prop to the surveys package that ignore the placement center check in the close outside click logic. Makes the survey modal close when clicking outside unless the user specifically restricted it by setting placement to center and disallowing click outside close in the survey.

Summary by CodeRabbit

• New Features
  • Added support for an optional setting to control click outside behavior in surveys, allowing for more flexible interaction handling.

[coderabbitai]

Walkthrough

A new optional property, ignorePlacementForClickOutside, has been added to the survey component's props and is now passed to the renderHtml function within the WebView component. This property is intended to control the behavior of click-outside events independently of placement logic. No other logic or functionality was changed.

Changes

Files/Paths	Change Summary
packages/react-native/src/components/survey-web-view.tsx	Added ignorePlacementForClickOutside: true to options in renderHtml within WebView.
packages/react-native/src/types/survey.ts	Added optional boolean ignorePlacementForClickOutside to SurveyBaseProps interface.

Assessment against linked issues

Objective	Addressed	Explanation
Enable closing the survey modal by clicking outside, unless disabled by a prop (#13)	❓	The new prop is introduced and passed, but there is no direct evidence of modal close logic.

Assessment against linked issues: Out-of-scope changes

Code Change	Explanation
None detected	All changes are related to introducing the new prop for click-outside behavior control.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 094fd9f and 3468c02.

📒 Files selected for processing (2)

• packages/react-native/src/components/survey-web-view.tsx (1 hunks)
• packages/react-native/src/types/survey.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: build
• GitHub Check: SonarQube
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

packages/react-native/src/types/survey.ts (1)

48-48: LGTM! Type definition is properly added.

The optional boolean property is correctly added to SurveyBaseProps and will be inherited by SurveyContainerProps through the extends relationship.

[reloaddev]

Hey @Dhruwang, it looks like you have been assigned to review this PR some time ago. You are probably busy with a lot of other stuff right now, so sorry for interrupting. Can you maybe give an update on the progress of this issue?

[pandeymangg]

closing this now, will be fixed with another PR