Skip to content

Conversation

@kamikazechaser
Copy link
Member

Users can now choose "sane" delimiter options such as:
"~", "+", "/", "#", among others.

Sticking with old ES5 syntax for forming strings.

Regex limits delimiters to certain sane delimiter values i.e. https://en.wikipedia.org/wiki/Delimiter-separated_values

Defaults to "-"

I think project is kinda old but we can add a tiny feature to it, probably not very useful though.

Users can now choose "sane" delimiter options such as:
"~", "+", "/", "#", among others.

Sticking with old ES5 syntax for forming strings.

Regex limits delimiters to certain sane delimiter values i.e. https://en.wikipedia.org/wiki/Delimiter-separated_values

Defaults to "-"
+ Example fixed & updated
@kamikazechaser
Copy link
Member Author

MFW i didn't see PR #2. FFS.

@kamikazechaser
Copy link
Member Author

kamikazechaser commented Jul 8, 2018

I guess the string padding at at the ends of the delimiter should be removed.

i.e " / " should be "/"

so the ids become "AA/001" instead of "AA / 001"

Though it should default to " - " as the project initially intended.

- Update regex to allow for white space at the ends between delimiters for more flexibility
- Update example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant