Fixes an issue where CMake clears the local variable instead of setting it (CMP0126) #190
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue occurs when using CMake 3.21+. The effect is that after setting the cache variables in the first lines of the main CMakeLists.txt they are not accessible anymore to the rest of the project and yield empty strings.
The first configure works though, only subsequent configures fail.
The bug could be alternatively fixed by setting the cmake_policy CMP0126 to old, however, I decided differently as it is deprecated behaviour.
Observed and fixed on CMake 3.31.5 by including memory as a subproject in my project.