Draft
Conversation
fmenabe
reviewed
Nov 1, 2023
Owner
fmenabe
left a comment
fmenabe
left a comment
There was a problem hiding this comment.
Hi, I review the PR. I have not much to say about type hints, I don't use them (yet) personally. I review hints and they seem coherents but I don't even know how to ensure they are correct (I used mypy on the file but not sure that's enough).
I also made comments about the addition of some variables instead of keeping the variables reassignments. Just curious is there a reason for this?
Contributor
Author
|
Please merge as-is ... I don't have much time anymore for annotations. But it is an incremental work anyway. Greetings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a draft, open to disscussion.
work can be split into two PR for an easier review: