feat: add retry with exponential backoff for artifact downloads#326
Merged
feat: add retry with exponential backoff for artifact downloads#326
Conversation
honnix
force-pushed
the
feat/retry-artifact-downloads
branch
2 times, most recently
from
50a9073 to
7d3e8ee
Compare
bergman
approved these changes
Mar 24, 2026
Extract generic Retries class from GrpcRetries and apply it in PackageLoader.handleArtifact to work around transient SSL failures (JDK SSLException/AEADBadTagException bug) during artifact downloads from cloud storage. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
honnix
force-pushed
the
feat/retry-artifact-downloads
branch
from
7d3e8ee to
ab60c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retriesclass fromGrpcRetries, parameterized with aPredicate<Exception>for retryability instead of hardcoded gRPC status codesPackageLoader.handleArtifactto work around transient SSL failures (JDKSSLException/AEADBadTagExceptionbug) during artifact downloads from cloud storageFlyteAdminClientmigrated to use the sharedRetriesclass with its gRPC-specific retry predicateTest plan
RetriesTestcovers gRPC retry scenarios (max attempts, successful retry, non-retryable, other exception)RetriesTestcovers IO retry scenarios (max attempts, successful retry, non-retryable)FlyteAdminClientTestpasses with newRetries-based setup🤖 Generated with Claude Code