feat(flytepropeller): add MaxConcurrentReconciles config for controller-runtime #7205#7206
Closed
parth0cb wants to merge 1 commit intoflyteorg:masterfrom
Closed
feat(flytepropeller): add MaxConcurrentReconciles config for controller-runtime #7205#7206parth0cb wants to merge 1 commit intoflyteorg:masterfrom
parth0cb wants to merge 1 commit intoflyteorg:masterfrom
Conversation
…er-runtime Adds configurable MaxConcurrentReconciles setting to allow users to tune the concurrency of reconcile loops in controller-runtime controllers. This setting is configurable via propeller.max-concurrent-reconciles config or the FLYTE_PROPELLER_MAX_CONCURRENTReconciles environment variable. Default value is 1 to match controller-runtime's conservative default. Closes #7205
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7206 +/- ##
==========================================
+ Coverage 56.95% 58.16% +1.21%
==========================================
Files 931 710 -221
Lines 58234 42227 -16007
==========================================
- Hits 33166 24563 -8603
+ Misses 22017 15435 -6582
+ Partials 3051 2229 -822
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds configurable
MaxConcurrentReconcilessetting to allow users to tune the concurrency of reconcile loops in controller-runtime controllers.Motivation
In our controller runtime init code, we can add
WithOptions(controller.Options{MaxConcurrentReconciles: <concurrent amount>})so that reconcile loops can be running concurrently. This setting should be configurable for users to easily adjust.Changes
MaxConcurrentReconcilesfield to propeller config (flytepropeller/pkg/controller/config/config.go)1to match controller-runtime's conservative defaultmanager.Optionsin:flytepropeller/cmd/controller/cmd/root.goflytepropeller/cmd/controller/cmd/webhook.gocmd/single/start.goUsage
Or via environment variable:
FLYTE_PROPELLER_MAX_CONCURRENTReconciles=4Closes #7205