fix: update init container config refs in primary spec#1925
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ApplyPrimaryConfigs rewrites ConfigMap/Secret refs in spec.Containers to use -primary copies, but skips spec.InitContainers entirely. GetTargetConfigs already tracks init container refs, so the primary copies get created, but the init containers in the primary deployment still point to the originals. Not great.
How to reproduce: deploy anything with an init container that pulls config from a ConfigMap or Secret via env/envFrom, let flagger init the primary, check the primary deployment spec - init containers still reference the original names.
Fix mirrors the existing containers loop for InitContainers. Also squashed a double-space typo in an error message while in the file.
Tests added to TestConfigTracker_ConfigMaps and TestConfigTracker_Secrets for both deployment and daemonset subtests.