Skip to content

fix(connectivity_plus): Use serial queue for NWPathMonitor to prevent race condition crash #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuel-goester-n41 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix(connectivity_plus): Use serial queue for NWPathMonitor to prevent race condition crash #3752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...lus/ios/connectivity_plus/Sources/connectivity_plus/PathMonitorConnectivityProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import Network

public class PathMonitorConnectivityProvider: NSObject, ConnectivityProvider {

// Use .utility, as it is intended for tasks that the user does not track actively.
// See: https://developer.apple.com/documentation/dispatch/dispatchqos
private let queue = DispatchQueue.global(qos: .utility)
// Use a serial queue to ensure that all network updates and monitor events happen
// sequentially, preventing race conditions during deallocation.
private let queue = DispatchQueue(label: "dev.fluttercommunity.plus.connectivity")

private var pathMonitor: NWPathMonitor?

Expand Down
6 changes: 3 additions & 3 deletions ...s/macos/connectivity_plus/Sources/connectivity_plus/PathMonitorConnectivityProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import Network

public class PathMonitorConnectivityProvider: NSObject, ConnectivityProvider {

// Use .utility, as it is intended for tasks that the user does not track actively.
// See: https://developer.apple.com/documentation/dispatch/dispatchqos
private let queue = DispatchQueue.global(qos: .utility)
// Use a serial queue to ensure that all network updates and monitor events happen
// sequentially, preventing race conditions during deallocation.
private let queue = DispatchQueue(label: "dev.fluttercommunity.plus.connectivity")

private var pathMonitor: NWPathMonitor?

Expand Down
Loading