You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The currently submitted PR can no longer pass the Android-side tests. I believe the relevant dependencies should be upgraded to allow the tests to run smoothly.
Checklist
I read the Contributor Guide and followed the process outlined there for submitting PRs.
@vbuberen
Sorry, I saw that you have a task to upgrade to SDK 36, but I recently submitted a PR that can no longer pass the Android tests because of my submission. This may conflict with your plan. Please check if the current PR needs to be closed.
Hi. Thanks for your draft PR, but it is something I am currently working on, but had no time to finish and open PRs properly. I would like to finish it myself as I have a bit different approach, since decided to use things like compileSDK from Flutter env variables. Additionally, my first of PRs that I started for android_alarm_manager_plus a few weeks ago had a bit different versions for Gradle, Kotlin, etc.
There will be PRs in next few days since I am finally back from recent travel and will have time to release all the changes for Android part of plugins. I am targeting early next week to release updates for all plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some adjustments.
targetSdk: 34 -> 36
compileSdk: 34 -> 36
gradle: 8.3.1 -> 8.6.0
kotlin: 1.7.22 -> 1.9.23
ndk: 27.0.12077973
The currently submitted PR can no longer pass the Android-side tests. I believe the relevant dependencies should be upgraded to allow the tests to run smoothly.
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).