Skip to content

Add design doc for macos-intel-deprecation#13398

Merged
parlough merged 1 commit into
mainfrom
vashworth-patch-1
May 18, 2026
Merged

Add design doc for macos-intel-deprecation#13398
parlough merged 1 commit into
mainfrom
vashworth-patch-1

Conversation

@vashworth
Copy link
Copy Markdown
Contributor

@vashworth vashworth commented May 18, 2026

Add /go/macos-intel-deprecation design doc redirect.

@vashworth vashworth requested review from a team and sfshaza2 as code owners May 18, 2026 20:19
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new 301 redirect to firebase.json for the macOS Intel deprecation document. The reviewer recommended removing the unnecessary usp=sharing query parameter from the destination URL to keep it concise and align with documentation style guidelines.

Comment thread firebase.json
{ "source": "/go/lints-migration", "destination": "/release/breaking-changes/flutter-lints-package", "type": 301 },
{ "source": "/go/localizing-datetime", "destination": "https://docs.google.com/document/d/1QR3qLXWdroTVLbnAQ8mq-Ia6tsZ8NY3lmi7gySQAstU/edit", "type": 301 },
{ "source": "/go/mac-voiceover-text-editing", "destination": "https://docs.google.com/document/d/19YP1o4Shba6NzQTBH_EWC8y1GUhKAbo9dan4digFbZs", "type": 301 },
{ "source": "/go/macos-intel-deprecation", "destination": "https://docs.google.com/document/d/1ty3js_Eg2sNIbDuyYS_aV7h4jYdx1hEpX_mV135gO4s/edit?usp=sharing", "type": 301 },
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The destination URL contains an unnecessary usp=sharing query parameter. According to the Google Developer Documentation Style Guidelines (which this PR aims to follow), URLs should be kept as simple and short as possible. Removing this parameter results in a cleaner redirect.

Suggested change
{ "source": "/go/macos-intel-deprecation", "destination": "https://docs.google.com/document/d/1ty3js_Eg2sNIbDuyYS_aV7h4jYdx1hEpX_mV135gO4s/edit?usp=sharing", "type": 301 },
{ "source": "/go/macos-intel-deprecation", "destination": "https://docs.google.com/document/d/1ty3js_Eg2sNIbDuyYS_aV7h4jYdx1hEpX_mV135gO4s/edit", "type": 301 },
References
  1. The Google Developer Documentation Style Guidelines recommend using the simplest, shortest URL possible. (link)

@flutter-website-bot
Copy link
Copy Markdown
Collaborator

Visit the preview URL for this PR (updated for commit 9918924):

https://flutter-docs-prod--pr13398-vashworth-patch-1-9n4qp8nw.web.app

Copy link
Copy Markdown
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vashworth!

@parlough parlough merged commit 9abbdd3 into main May 18, 2026
10 checks passed
@parlough parlough deleted the vashworth-patch-1 branch May 18, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants