Skip to content

Adding instructions on using Swift Package Manager#13359

Merged
sfshaza2 merged 6 commits into
mainfrom
update-developing-packages-spm
May 12, 2026
Merged

Adding instructions on using Swift Package Manager#13359
sfshaza2 merged 6 commits into
mainfrom
update-developing-packages-spm

Conversation

@sfshaza2
Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 commented May 6, 2026

Fixes #13283

@sfshaza2 sfshaza2 requested a review from johnpryan May 6, 2026 04:47
@sfshaza2 sfshaza2 requested a review from a team as a code owner May 6, 2026 04:47
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for developing Flutter packages, specifically focusing on native Darwin dependencies. It promotes Swift Package Manager as the primary strategy for iOS and macOS dependencies and moves CocoaPods instructions to a legacy section. The review feedback correctly identifies an error in the recommended file path for the Package.swift file and a syntax error (a trailing backtick) in a Ruby code example.

Comment thread sites/docs/src/content/packages-and-plugins/developing-packages.md Outdated
Comment thread sites/docs/src/content/packages-and-plugins/developing-packages.md Outdated
@flutter-website-bot
Copy link
Copy Markdown
Collaborator

flutter-website-bot commented May 6, 2026 •
edited
Loading

Visit the preview URL for this PR (updated for commit 5275cfb):

https://flutter-docs-prod--pr13359-update-developing-packages-t73b1owr.web.app

@parlough parlough requested a review from loic-sharma May 6, 2026 19:54
@sfshaza2
Copy link
Copy Markdown
Contributor Author

sfshaza2 commented May 7, 2026

@johnpryan, can you review?

johnpryan
johnpryan reviewed May 12, 2026
View reviewed changes
Comment thread sites/docs/src/content/packages-and-plugins/developing-packages.md Outdated
johnpryan
johnpryan reviewed May 12, 2026
View reviewed changes
Comment thread sites/docs/src/content/packages-and-plugins/developing-packages.md Outdated
johnpryan
johnpryan approved these changes May 12, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment about what folder the the SwiftPM plugin code should live in.

@sfshaza2 sfshaza2 merged commit 6ee766f into main May 12, 2026
10 checks passed
@sfshaza2 sfshaza2 deleted the update-developing-packages-spm branch May 12, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnpryan johnpryan johnpryan approved these changes

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update "Developing packages" page to use Swift Package Manager

3 participants

@sfshaza2 @flutter-website-bot @johnpryan