Fix broken link on internationalization page#13056
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @hitochan777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where documentation links to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request addresses broken links on the internationalization page for DateFormat and NumberFormat. The changes correctly update the URL paths to point to the correct API documentation within the package-intl_intl namespace. The fix is accurate and improves the quality of the documentation. Well done!
parlough
left a comment
There was a problem hiding this comment.
Thanks for catching these issues and opening a PR to fix them @hitochan777!
However, before we can properly review and merge your PR, you'll need to sign the Google CLA as outlined by the earlier CLA bot comment.
If you have any issues doing so, please let us know. Thanks again!
|
@parlough Thank you for letting me know! I signed the Google CLA. |
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit ac67313): |
parlough
left a comment
There was a problem hiding this comment.
Thanks again for this fix and for signing the CLA. Looks good to me!
Clicking on links to DateFormat and NumberFormat leads to 404 page.
I fixed this by changing path to
/flutter/package-intl_intlfrom/flutter/intl(Sorry if you intend to link to other websites).Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist
of 80 characters or fewer.