Skip to content

Fix broken link on internationalization page#13056

Merged
parlough merged 2 commits intoflutter:mainfrom
hitochan777:patch-1
Feb 14, 2026
Merged

Fix broken link on internationalization page#13056
parlough merged 2 commits intoflutter:mainfrom
hitochan777:patch-1

Conversation

@hitochan777
Copy link
Contributor

@hitochan777 hitochan777 commented Feb 11, 2026

Clicking on links to DateFormat and NumberFormat leads to 404 page.
I fixed this by changing path to /flutter/package-intl_intl from /flutter/intl (Sorry if you intend to link to other websites).

Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@hitochan777 hitochan777 requested review from a team and sfshaza2 as code owners February 11, 2026 07:32
@google-cla
Copy link

google-cla bot commented Feb 11, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hitochan777, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where documentation links to the DateFormat and NumberFormat classes on the internationalization page were incorrect, resulting in 404 errors. By updating the paths to reference the package-intl_intl format, the PR ensures that users can now correctly navigate to the relevant API documentation, enhancing the accuracy and user experience of the internationalization guide.

Highlights

  • Broken Link Fix: Corrected broken links for DateFormat and NumberFormat classes on the internationalization documentation page, which previously led to 404 errors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/content/ui/internationalization/index.md
    • Updated the URL for the NumberFormat class to point to the correct package-intl_intl path.
    • Updated the URL for the DateFormat class to point to the correct package-intl_intl path.
Activity
  • No specific activity (comments, reviews, or progress updates) was found in the provided context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses broken links on the internationalization page for DateFormat and NumberFormat. The changes correctly update the URL paths to point to the correct API documentation within the package-intl_intl namespace. The fix is accurate and improves the quality of the documentation. Well done!

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching these issues and opening a PR to fix them @hitochan777!

However, before we can properly review and merge your PR, you'll need to sign the Google CLA as outlined by the earlier CLA bot comment.

If you have any issues doing so, please let us know. Thanks again!

@sfshaza2 sfshaza2 added the cla: no Contributor has not signed the Contributor License Agreement label Feb 11, 2026
@google-cla google-cla bot added cla: yes Contributor has signed the Contributor License Agreement and removed cla: no Contributor has not signed the Contributor License Agreement labels Feb 14, 2026
@hitochan777
Copy link
Contributor Author

@parlough Thank you for letting me know! I signed the Google CLA.

@hitochan777 hitochan777 requested a review from parlough February 14, 2026 08:29
@parlough
Copy link
Member

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit ac67313):

https://flutter-docs-prod--pr13056-patch-1-b0fi6t14.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this fix and for signing the CLA. Looks good to me!

@parlough parlough merged commit 14df4be into flutter:main Feb 14, 2026
10 checks passed
@hitochan777 hitochan777 deleted the patch-1 branch February 14, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants