Skip to content

[webview_flutter_platform_interface] Add support for getting cookie#11037

Open
khaled-0 wants to merge 1 commit intoflutter:mainfrom
khaled-0:platform
Open

[webview_flutter_platform_interface] Add support for getting cookie#11037
khaled-0 wants to merge 1 commit intoflutter:mainfrom
khaled-0:platform

Conversation

@khaled-0
Copy link

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

#10833

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for retrieving cookies by adding a getCookies method to the PlatformWebViewCookieManager interface. The changes are well-contained within the platform interface package, including necessary updates to pubspec.yaml and CHANGELOG.md. My review focuses on improving documentation clarity and ensuring test coverage for the new functionality, in line with repository guidelines.

Comment on lines +70 to +74
Future<List<WebViewCookie>> getCookies(Uri url) {
throw UnimplementedError(
'getCookies is not implemented on the current platform',
);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The repository's contribution guide requires that code changes are tested. Please add a unit test for the new getCookies method to verify that its default implementation throws an UnimplementedError.

References
  1. The style guide states that code should be tested. (link)

);
}

/// Gets a list of existing cookie for specified domain from all

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's a minor typo in the documentation. It should be 'cookies' (plural) to be consistent with the method returning a list.

Suggested change
/// Gets a list of existing cookie for specified domain from all
/// Gets a list of existing cookies for specified domain from all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant