[webview_flutter_platform_interface] Add support for getting cookie#11037
[webview_flutter_platform_interface] Add support for getting cookie#11037khaled-0 wants to merge 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request introduces support for retrieving cookies by adding a getCookies method to the PlatformWebViewCookieManager interface. The changes are well-contained within the platform interface package, including necessary updates to pubspec.yaml and CHANGELOG.md. My review focuses on improving documentation clarity and ensuring test coverage for the new functionality, in line with repository guidelines.
| Future<List<WebViewCookie>> getCookies(Uri url) { | ||
| throw UnimplementedError( | ||
| 'getCookies is not implemented on the current platform', | ||
| ); | ||
| } |
There was a problem hiding this comment.
The repository's contribution guide requires that code changes are tested. Please add a unit test for the new getCookies method to verify that its default implementation throws an UnimplementedError.
References
- The style guide states that code should be tested. (link)
| ); | ||
| } | ||
|
|
||
| /// Gets a list of existing cookie for specified domain from all |
There was a problem hiding this comment.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
#10833
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3