Skip to content

Conversation

@Frank3K
Copy link
Contributor

@Frank3K Frank3K commented Jan 27, 2026

Description

Follow-up to #10703 which added WOFF/WOFF2 support for web.

The previous implementation iterated through manifest assets first, then checked file extensions. This meant if a .ttf file appeared before a .woff2 file in the manifest, the .ttf would be selected even though .woff2 should be preferred on web.

This fix inverts the loop order to iterate by file type priority first (woff2 > woff > ttf > otf on web), ensuring the preferred format is selected regardless of manifest order.


While working on #10703 I already looked at the specific for-loop, but not immediately notice this might be an issue. For Flutter projects with web-only support it is not; one can just include the woff2 fonts only. But for cross-platform projects it is an issue. Sample from an assets.gen.dart file:

  /// File path: assets/google_fonts/Roboto-Regular.ttf
  String get robotoRegularTtf => 'assets/google_fonts/Roboto-Regular.ttf';

  /// File path: assets/google_fonts/Roboto-Regular.woff2
  String get robotoRegularWoff2 => 'assets/google_fonts/Roboto-Regular.woff2';

With the old loop, the .ttf would be selected, even though a better alternative (the .woff2) is present.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Follow-up to flutter#10703 which added WOFF/WOFF2 support for web.

The previous implementation iterated through manifest assets first, then
checked file extensions. This meant if a .ttf file appeared before a
.woff2 file in the manifest, the .ttf would be selected even though
.woff2 should be preferred on web.

This fix inverts the loop order to iterate by file type priority first
(woff2 > woff > ttf > otf on web), ensuring the preferred format is
selected regardless of manifest order.
@Frank3K Frank3K requested a review from Piinks as a code owner January 27, 2026 06:00
@github-actions github-actions bot added p: google_fonts triage-framework Should be looked at in framework triage labels Jan 27, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in how bundled font assets are selected. The logic in findFamilyWithVariantAssetPath has been changed to prioritize more optimized font formats (like WOFF2/WOFF on web) over others, regardless of their order in the asset manifest. This is achieved by iterating through a list of preferred file types first, then searching the manifest for a matching asset. The change is supported by an updated test to verify the new behavior, a version bump to 8.0.1, and a corresponding changelog entry.

@Frank3K
Copy link
Contributor Author

Frank3K commented Jan 27, 2026

@guidezpl This is a bug fix for #10703, which you reviewed last week. Could you take a look at this fix?

Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with guidance on asset manifests which says that the order doesn't matter

██╗      ██████╗ ████████╗███╗   ███╗
██║     ██╔════╝ ╚══██╔══╝████╗ ████║
██║     ██║  ███╗   ██║   ██╔████╔██║
██║     ██║   ██║   ██║   ██║╚██╔╝██║
███████╗╚██████╔╝   ██║   ██║ ╚═╝ ██║
╚══════╝ ╚═════╝    ╚═╝   ╚═╝     ╚═╝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: google_fonts triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants