[camera_avfoundation] ios saving path

[ivan-vanyusho]

Description

Changed iOS file storage path from documentDirectory to temporaryDirectory to ensure consistency with Android where files are stored in cache directory.

Changes

• iOS now uses temporaryDirectory instead of documentDirectory for consistency with Android

Code changes

// Before:
let documentDirectory = FileManager.default.urls(
      for: .documentDirectory,
      in: .userDomainMask)[0]

// After:
let documentDirectory = FileManager.default.temporaryDirectory

Issues

flutter/flutter#166933

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[gemini-code-assist]

Code Review

This pull request correctly changes the iOS file storage path from documentDirectory to temporaryDirectory to align with Android's behavior, improving cross-platform consistency. I have one suggestion to improve code clarity by renaming a variable that became misleading due to this change.

[stuartmorgan-g]

Thanks for the submission! This will need the remaining items in the checklist addressed before it moves forward with review. If you have any questions about completing those steps that aren’t addressed in the linked documentation, please let us know.

[gemini-code-assist]

Code Review

The pull request updates the iOS camera plugin to store captured pictures and videos in the system's temporaryDirectory instead of the application's documentDirectory. This change aligns the iOS behavior with Android's cache directory usage. The CHANGELOG.md has been updated to reflect this as a breaking change, and the pubspec.yaml version has been incremented accordingly.

[stuartmorgan-g]

This still needs tests before it can be reviewed, per the checklist.

[gemini-code-assist]

Code Review

This pull request successfully updates the iOS file storage path for camera pictures and videos from the application's documentDirectory to the temporaryDirectory, aligning with Android's cache directory usage for consistency. The change is well-supported by a new test case that verifies the updated storage location. The CHANGELOG.md and pubspec.yaml files have been updated appropriately.

[gemini-code-assist]

The expectedPath is hardcoded as "/tmp/camera/pictures/". While this is correct for the current implementation, it could be more robust to derive this path dynamically within the test, perhaps by calling the same utility function that constructs the path in DefaultCamera.swift (if exposed or mockable), or by inspecting FileManager.default.temporaryDirectory and appending the known subpaths. This would make the test less brittle if the subfolder structure changes in the future.

[hellohuanlin]

iOS now uses temporaryDirectory instead of documentDirectory for consistency with Android

I don't see why we want this "consistency". Apple's recommendation is to use documentDirectory for user generated files (so that it could be exported when connected to mac).

To fix the broken file, we could either (1) save to temp directory first, and move to document directory once done, or (2) save to document directory, and delete if error happens.

[LouiseHsu]

iOS now uses temporaryDirectory instead of documentDirectory for consistency with Android

I don't see why we want this "consistency". Apple's recommendation is to use documentDirectory for user generated files (so that it could be exported when connected to mac).

To fix the broken file, we could either (1) save to temp directory first, and move to document directory once done, or (2) save to document directory, and delete if error happens.

to be fair, the method the change is in is literally called getTemporaryFilePath. It does seem misleading for that method to originally return the Documents folder which is persistent instead of the tmp folder.

[hellohuanlin]

to be fair, the method the change is in is literally called getTemporaryFilePath. It does seem misleading for that method to originally return the Documents folder which is persistent instead of the tmp folder.

Good catch @LouiseHsu. I missed this part. If it's intended to save to temp path, then we should use temp path.

[LouiseHsu]

LGTM. I worry a little that this may unintentionally break certain implementations for people who were relying on the videos being incorrectly saved to the documents folder, but its probably fine lol.

[hellohuanlin]

I worry a little that this may unintentionally break certain implementations for people who were relying on the videos being incorrectly saved to the documents folder, but its probably fine lol.

The path (documentDirectory/camera/pictures/) isn't public API so unlikely developers would use it.

[LouiseHsu]

sorry, looks like there are some conflicts. once you resolve those we can merge :)

[stuartmorgan-g]

@LouiseHsu FYI, changelog and version conflicts are usually trivial for us to resolve in the GitHub UI.

@hellohuanlin If you are adding the final approval for a non-team PR, and there are no follow-up changes to make, please add autosubmit at that point.

[auto-submit]

autosubmit label was removed for flutter/packages/10832, because This PR has not met approval requirements for merging. Changes were requested by {stuartmorgan-g}, please make the needed changes and resubmit this PR.
The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

• Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Obsolete