Include mouse back and forward buttons on Linux mouse events.#57287
Include mouse back and forward buttons on Linux mouse events.#572872bndy5 wants to merge 1 commit intoflutter:mainfrom 2bndy5:feature-request-152128
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
This repository is no longer in use - this change should be proposed to https://github.com/flutter/flutter which now contains the engine. |
|
I did review the change, however I'm not sure if buttons 4 and 5 map to back and forward on all mice. Looking at the GTK source it seems buttons 4-7 map to scroll up/down/left/right on X11, and Wayland it states: Which I think is incorrect, as this will still set the fourth button will still be set to ID 4. In Flutters which I think we should also be doing for any remaining buttons. |
|
I finally got around to testing this... Apparently, the mouse back and forward buttons register as 8 & 9 respectively (in case 8:
*button = kFlutterPointerButtonMouseBack;
return TRUE;
case 9:
*button = kFlutterPointerButtonMouseForward;
return TRUE; |
Like the title says, this includes the mouse's backward and forward buttons reported mouse events.
resolves flutter/flutter#152128
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.