feat: add E2E deployment test for Fluentd#1849
Open
ishaanxgupta wants to merge 4 commits intofluent:masterfrom
Open
feat: add E2E deployment test for Fluentd#1849ishaanxgupta wants to merge 4 commits intofluent:masterfrom
ishaanxgupta wants to merge 4 commits intofluent:masterfrom
Conversation
hemang1404
force-pushed
the
add-e2e-deployment-test
branch
from
3b92e10 to
88adab9
Compare
Author
|
@marcofranssen @joshuabaird please have a look |
hemang1404
force-pushed
the
add-e2e-deployment-test
branch
2 times, most recently
from
414245a to
784c512
Compare
Author
|
@marcofranssen @joshuabaird awaiting your review on this one |
Collaborator
|
@ishaanxgupta the test failed itself, see https://github.com/fluent/fluent-operator/actions/runs/21453174637/job/62003022673?pr=1849, please fix it first. Thank you. |
hemang1404
force-pushed
the
add-e2e-deployment-test
branch
from
784c512 to
9f4aa55
Compare
- Added E2E deployment test for Fluentd with EmptyDir buffers for CI runners. - Enabled manual triggering (workflow_dispatch) for E2E CI workflows. - Fixed Helm linting by using local dependency paths for unreleased charts. - Tidied Go modules. Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
The E2E test was failing because the Fluentd image ghcr.io/fluent/fluent-operator/fluentd:v1.19.1 wasn't available in the Kind cluster. This commit adds the missing step to build the Fluentd image using make build-fd-amd64 and load it into the Kind cluster before running the e2e tests. Resolves ImagePullBackOff error in CI. Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
The Fluentd Dockerfile requires FLUENTD_BASE_VERSION to be set, but the Makefile wasn't passing it. This caused builds to fail with 'fluent/fluentd:v-debian: not found'. Now reading the version from cmd/fluent-watcher/fluentd/VERSION file and passing it as --build-arg to match the GitHub workflow behavior. Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
hemang1404
force-pushed
the
add-e2e-deployment-test
branch
from
9f4aa55 to
e2c4192
Compare
- Trim whitespace from FLUENTD_BASE_VERSION to avoid CRLF issues - Use FD_IMG variable in e2e script to avoid image tag drift - Add comment explaining check-version-increment disable rationale Signed-off-by: hemang1404 <hemangsharrma@gmail.com>
Author
|
@cw-Guo tested on local, the tests should pass this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test creates a Fluentd CR with FluentdConfig and ClusterOutput, waits for the operator to create a StatefulSet, and verifies that pods are running with all containers ready.
The test:
Executed automatically by the existing
test-e2e.ymlworkflow.Fixes #1733
Collaborated with @hemang1404