ci: pin trivy-action to safe SHA to mitigate supply chain attack#11612
ci: pin trivy-action to safe SHA to mitigate supply chain attack#11612artemry-nv wants to merge 1 commit intofluent:masterfrom
Conversation
Pin all aquasecurity/trivy-action references from @master to @57a97c7e7821a5776cebc9bb87c984fa69cba8f1 (v0.35.0) in response to active cybersecurity campaign targeting Trivy (GHSA-69fq-xp46-6x23).
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files update Trivy security scanning steps by pinning the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Important Merge conflicts detected (Beta)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/cron-trivy.yaml (1)
53-55: Stale comment should be updated.The comment on line 53 stating "Deliberately chosen master here to keep up-to-date" is now outdated since the action is pinned to a specific SHA. Consider updating or removing this comment to reflect the new pinning strategy and avoid confusion for future maintainers.
📝 Suggested comment update
- # Deliberately chosen master here to keep up-to-date. + # Pinned to specific SHA for supply chain security (CVE GHSA-69fq-xp46-6x23). + # Review and update periodically to newer safe versions. - name: Run Trivy vulnerability scanner for any major issues uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1 # v0.35.0 (pinned for CVE GHSA-69fq-xp46-6x23)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/cron-trivy.yaml around lines 53 - 55, Update the outdated inline comment "Deliberately chosen master here to keep up-to-date" (above the uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1) to reflect that the action is pinned to a specific SHA, or remove it entirely; find the comment near the uses: line in cron-trivy.yaml and either replace the text with a concise note about the intentional SHA pin (e.g., "Pinned to specific SHA for reproducible scans and CVE workaround") or delete the comment to avoid confusion for future maintainers.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/cron-trivy.yaml:
- Around line 53-55: Update the outdated inline comment "Deliberately chosen
master here to keep up-to-date" (above the uses:
aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1) to reflect
that the action is pinned to a specific SHA, or remove it entirely; find the
comment near the uses: line in cron-trivy.yaml and either replace the text with
a concise note about the intentional SHA pin (e.g., "Pinned to specific SHA for
reproducible scans and CVE workaround") or delete the comment to avoid confusion
for future maintainers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d381b605-94bf-42d5-a2b5-d4179770e858
📒 Files selected for processing (2)
.github/workflows/call-build-images.yaml.github/workflows/cron-trivy.yaml
Pin all aquasecurity/trivy-action references from @master to @57a97c7e7821a5776cebc9bb87c984fa69cba8f1 (v0.35.0) in response to active cybersecurity campaign targeting Trivy (GHSA-69fq-xp46-6x23).
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit