docs: out_opentelemetry: Add 'encoding' option for OTLP/HTTP JSON export#2587
docs: out_opentelemetry: Add 'encoding' option for OTLP/HTTP JSON export#2587meehanman wants to merge 5 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates ChangesOpenTelemetry Output Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Dean Meehan <d3an.meehan@hotmail.com>
15457c5 to
f10cd68
Compare
eschabell
left a comment
There was a problem hiding this comment.
@meehanman thanks for the docs PR, just a few vale issues to address.
Signed-off-by: Dean Meehan <d3an.meehan@hotmail.com>
3081ca4 to
56e55c0
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/outputs/opentelemetry.md`:
- Line 40: The description for logs_body_key is a sentence fragment; update the
paragraph for the `logs_body_key` entry so it is a complete sentence (e.g.,
"This option can be specified multiple times."). Edit the table row for
`logs_body_key` to replace "Can be specified multiple times." with a full
sentence while preserving the rest of the text and formatting, ensuring
consistency with other table entries.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2413febc-cf28-4da0-b8a7-c89d90f2ee24
📒 Files selected for processing (1)
pipeline/outputs/opentelemetry.md
Signed-off-by: Dean Meehan <d3an.meehan@hotmail.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pipeline/outputs/opentelemetry.md`:
- Line 120: The sentence implying generic HTTP webhook compatibility is
misleading; update the line that mentions "encoding json" and "Content-Type:
application/json" to clarify that OTLP JSON is accepted only by OTLP/HTTP
receivers that explicitly support JSON encoding (not arbitrary webhooks).
Replace "such as HTTP webhook endpoints" with wording like "for OTLP/HTTP
receivers that explicitly support JSON encoding" and ensure the explanation
stays technical and neutral, referencing the "encoding json" option and the
resulting "Content-Type: application/json" header.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d0e8013d-dd4c-4716-8527-6807680611fd
📒 Files selected for processing (1)
pipeline/outputs/opentelemetry.md
Signed-off-by: Dean Meehan <d3an.meehan@hotmail.com>
Signed-off-by: Dean Meehan <d3an.meehan@hotmail.com>
eschabell
left a comment
There was a problem hiding this comment.
@meehanman a simple vale issue.
| {% hint style="info" %} | ||
| The `encoding` option applies to **OTLP/HTTP** exports only. When `grpc` is `on`, logs, metrics, and traces are sent over OTLP/gRPC using protobuf framing. | ||
|
|
||
| Profiles are always sent as protobuf regardless of the `encoding` setting — no OTLP JSON encoder exists for the profiles signal yet. |
There was a problem hiding this comment.
@meehanman I'd just replace the - with a comma to fix this issue, as that does not change the meaning?
Documentation required for PR
out_opentelemetry: Add 'encoding' option for OTLP/HTTP JSON exportwhich adds anencodingconfiguration option to theout_opentelemetryplugin that controls whether OTLP data is exported as protobuf (default, existing behavior) or JSON (Content-Type: application/json) over HTTP.While I was at it there are also included Clarifications & rewrites
encodingonly applies to OTLP/HTTP (not gRPC), and that profiles always use protobuf regardless.grpcoption description to remove the misleadingautovalue and clarify it enables HTTP/2 automatically.logs_*keys — replacing generic "Specify a X key" placeholders with accurate descriptions of whether the key reads from the record body vs. metadata.logs_body_keybehaviour: multiple values allowed, first match wins, defaults to$logthen$message.Summary by CodeRabbit