Skip to content

administration: monitoring: add docs for new processor metrics#2566

Open
lecaros wants to merge 1 commit intomasterfrom
lecaros-processor-metrics
Open

administration: monitoring: add docs for new processor metrics#2566
lecaros wants to merge 1 commit intomasterfrom
lecaros-processor-metrics

Conversation

@lecaros
Copy link
Copy Markdown
Contributor

@lecaros lecaros commented May 5, 2026

This was added in PR fluent/fluent-bit#11518

Summary by CodeRabbit

  • Documentation
    • Added documentation for Fluent Bit v2 Prometheus metrics, including processor-related metrics for errors, invocations, and item flow counters with relevant labels for improved monitoring visibility.

Signed-off-by: lecaros <lecaros@chronosphere.io>
@lecaros lecaros requested review from a team and eschabell as code owners May 5, 2026 12:16
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 5, 2026

📝 Walkthrough

Walkthrough

Documentation was added to the monitoring guide describing new Fluent Bit v2 Prometheus metrics for processor units, including error counts, invocation totals, and item flow counters with associated labels. The v2 metrics table was reordered to list processor metrics before existing uptime and build-info entries.

Changes

Processor Metrics Documentation

Layer / File(s) Summary
Documentation
administration/monitoring.md
Six new processor-related Prometheus metrics (fluentbit_processor_errors_total, fluentbit_processor_invocations_total, fluentbit_processor_items_in_total, fluentbit_processor_items_out_total, fluentbit_processor_items_add_total, fluentbit_processor_items_drop_total) documented in the v2 metrics table with scope/owner/processor/stage/signal labels. Existing uptime/build-info/hot-reload metric rows repositioned after new processor metrics.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

5.0

Suggested reviewers

  • patrick-stephens
  • cosmo0920

Poem

🐰 Metrics bloom in rows so neat,
Processor counters, oh what a treat!
Items flowing, errors too,
Documentation fresh and true!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'administration: monitoring: add docs for new processor metrics' accurately and specifically describes the main change: adding documentation for new processor metrics in the monitoring section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lecaros-processor-metrics

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
administration/monitoring.md (1)

237-240: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Remove duplicate metric entries from the table.

The metrics fluentbit_build_info and fluentbit_hot_reloaded_times appear twice in the same table:

  • fluentbit_build_info: Line 198 and Line 239
  • fluentbit_hot_reloaded_times: Line 203 and Line 240

This creates confusion and inconsistency in the documentation. Please remove the duplicate entries at lines 239-240.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@administration/monitoring.md` around lines 237 - 240, Remove the duplicate
metric rows for fluentbit_build_info and fluentbit_hot_reloaded_times in the
metrics table so each metric appears only once; specifically delete the repeated
entries that list `fluentbit_build_info` and `fluentbit_hot_reloaded_times` (the
later occurrences) and ensure the remaining rows for those metrics retain the
correct labels, descriptions, and types as shown in the original entries for
`fluentbit_build_info` and `fluentbit_hot_reloaded_times`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@administration/monitoring.md`:
- Around line 237-240: Remove the duplicate metric rows for fluentbit_build_info
and fluentbit_hot_reloaded_times in the metrics table so each metric appears
only once; specifically delete the repeated entries that list
`fluentbit_build_info` and `fluentbit_hot_reloaded_times` (the later
occurrences) and ensure the remaining rows for those metrics retain the correct
labels, descriptions, and types as shown in the original entries for
`fluentbit_build_info` and `fluentbit_hot_reloaded_times`.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c35234d4-f706-40ba-a584-0648ea40e585

📥 Commits

Reviewing files that changed from the base of the PR and between 4f4e372 and cf01569.

📒 Files selected for processing (1)
  • administration/monitoring.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant