docs: outputs: exit: update doc and add example#2429
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughDocumentation for the exit plugin was updated with renamed configuration parameters (snake_case convention), modified default values from "none" to "-1", and a new "Get started" section containing usage examples in YAML and text configuration formats. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.Add a .trivyignore file to your project to customize which findings Trivy reports. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/exit.md`:
- Line 53: Update the classic fluent-bit.conf example to use Title_Case for the
plugin key by changing the incorrect "Record_count" entry to the canonical
"Record_Count" so the example matches docs conventions for plugin-specific keys;
locate the occurrence of "Record_count 5" in the exit output example and replace
it with "Record_Count 5".
|
@cosmo0920 and @patrick-stephens ready for review! |
|
@patrick-stephens fixed it, ready for review! |
- Lowercase Key column entries in parameter table - Fix all defaults: _none_ -> -1 - Sort table alphabetically - Fix extra space before _none_ on record_count row - Add missing period to flush_count description - Add Get started section with YAML and classic config examples using record_count - Fix → in classic config example Applies to fluent#2412 Signed-off-by: Eric D. Schabell <eric@schabell.org>
fcc4ed9 to
f6bd83f
Compare
Applies to #2412
Summary by CodeRabbit