docs: outputs: skywalking: fix table header, sort order, host default, classic key casing#2424
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation for the Apache SkyWalking output was updated: table header changed to "Key", an Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
|
@cosmo0920 and @patrick-stephens ready for review! |
87e01cf to
2087bb2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/skywalking.md`:
- Around line 51-52: Replace the underscored classic config keys `Svc_name` and
`Svc_inst_name` with Title_Case `SvcName` and `SvcInstName` respectively; locate
all occurrences (e.g., the entries showing "Svc_name dummy-service" and
"Svc_inst_name dummy-service-fluentbit") and update the key names, preserving
their values and spacing/formatting, and run any config validation or tests that
parse these keys to ensure nothing else relies on the old underscored names.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e30e2e08-4e24-4b9a-93b8-f853f6f9ac6a
📒 Files selected for processing (1)
pipeline/outputs/skywalking.md
|
@patrick-stephens fixing the issue, ready for review! |
…, classic key casing - Fix table column header: "Parameter" -> "Key" for consistency with other output plugin docs - Remove redundant "This plugin supports the following parameters:" intro sentence - Sort configuration parameters table alphabetically - Fix stray space in host default value - Apply Title_Case to classic config keys: Svc_name, Svc_inst_name - Fix classic config key casing to Title_Case Applies to fluent#2412 Signed-off-by: Eric D. Schabell <eric@schabell.org>
2087bb2 to
fd9dcb6
Compare
Applies to #2412
Summary by CodeRabbit