Skip to content

Add documentation for systemd per-service parsing configuration#1508

Open
seveas wants to merge 5 commits into
fluent:masterfrom
seveas:systemd-parser
Open

Add documentation for systemd per-service parsing configuration#1508
seveas wants to merge 5 commits into
fluent:masterfrom
seveas:systemd-parser

Conversation

@seveas
Copy link
Copy Markdown
Contributor

@seveas seveas commented Nov 8, 2024

This documents the functionality added in fluent/fluent-bit#9567

@seveas seveas requested review from a team as code owners November 8, 2024 09:46
@seveas
Add documentation for systemd per-service parsing configuration
6928c51 
Signed-off-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
@eschabell eschabell requested a review from esmerel October 22, 2025 00:07
@eschabell eschabell self-assigned this Oct 22, 2025
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor waiting-on-review Waiting on a review from mainteners labels Oct 22, 2025
@eschabell
Copy link
Copy Markdown
Collaborator

eschabell commented Oct 22, 2025

@esmerel can you give this a look?

@eschabell
Copy link
Copy Markdown
Collaborator

eschabell commented Oct 22, 2025

@seveas can you resolve the conflicts here? I also nudged you on the code PR fluent/fluent-bit#9567 for actions needed to proceed there.

esmerel
esmerel approved these changes Oct 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor edit suggestions

Comment thread pipeline/inputs/systemd.md Outdated
Comment thread pipeline/inputs/systemd.md Outdated
@esmerel
Copy link
Copy Markdown
Contributor

esmerel commented Oct 28, 2025

It also looks like the conflict can be resolved safely by accepting the incoming changes, but github has a bad habit of marking suggestions as outdated when you merge things so I'm not doing it myself this time.

@eschabell eschabell added 4.2.1 and removed 4.2.1 waiting-for-user Waiting for user/contributors feedback or requested changes waiting-on-review Waiting on a review from mainteners labels Dec 3, 2025
@eschabell @esmerel
Update pipeline/inputs/systemd.md
dc6ee1b 
Co-authored-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-requested a review as a code owner May 27, 2026 14:40
@eschabell @esmerel
Update pipeline/inputs/systemd.md
b54db8f 
Co-authored-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026 •
edited
Loading

Warning

Review limit reached

@eschabell, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 52 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b4ea09fd-709f-4d10-8c17-db8c0d9607d4

📥 Commits

Reviewing files that changed from the base of the PR and between 5231934 and 3c341ea.

📒 Files selected for processing (1)
  • pipeline/inputs/systemd.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Merge branch 'master' into systemd-parser
8a50705 
Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
Copy link
Copy Markdown
Collaborator

eschabell commented May 27, 2026

@seveas tackled the conflicts for you.

@eschabell
docs: pipeline: inputs: systemd: fix Vale suggestions
3c341ea 
  - Replace 'is not' with contraction 'isn't'
  - Reword 'unparsed message' to avoid Vale spelling suggestion

  Applies to fluent#1508

Signed-off-by: Eric D. Schabell <eric@schabell.org>
eschabell
eschabell approved these changes May 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seveas just waiting on code PR merging.

@eschabell eschabell removed the conflict Waiting on conflict to be resolved by contributor label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eschabell eschabell eschabell approved these changes

@esmerel esmerel esmerel approved these changes

Assignees

@eschabell eschabell

Labels

waiting-on-code-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seveas @eschabell @esmerel @lecaros