Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change#1449
Make the 3.1 notes more prominent in kubernetes-events.md as this is a breaking change#1449douglasawh wants to merge 5 commits into
Conversation
This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate. The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users. Signed-off-by: Doug Whitfield <dwhitfield@perforce.com>
lockewritesdocs
left a comment
There was a problem hiding this comment.
Thanks for your contribution @douglasawh! I suggested some editorial changes to incorporate.
This language much better than my original PR. All I *had* done is take what was in there, reformat it slightly, and move it to the top. Co-authored-by: Adam Locke <adam.locke@chronosphere.io> Signed-off-by: Doug Whitfield <douglasawh@gmail.com>
|
Hi @douglasawh, Thanks |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
@douglasawh can you please fix the conflicts here so I can merge for you? |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
The conflicts were due to formatting changes for style, I went ahead and fixed the conflicts in the interest of keeping things moving. |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
|
The DCO failure is a hard block |
|
@douglasawh if you can look at the DCO failures, we've pushed through the original conflicts for you, would love to have this PR in a clean state to merge? |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR updates the Kubernetes Events input plugin configuration documentation by renaming the section header and revising the configuration parameters table. Key defaults are clarified, including ChangesKubernetes Events Configuration Documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@douglasawh you need to fix this yourself and we can merge this change: "Commit sha: 62bfca7, Author: Doug Whitfield, Committer: GitHub; Expected "Doug Whitfield dwhitfield@perforce.com", but got "Doug Whitfield douglasawh@gmail.com"." |
This is a pretty massive change in the way the plugin works. Sticking this at the bottom in a foot note does not seem appropriate.
The decision to do this initially does make some sense, as 3.1 is not going to be the version that everyone is using. However, over time, this will come to be the dominant behavior, and that behavior should be made clear to the users.
Summary by CodeRabbit