Skip to content

in_kafka: Add async_commit description#1385

Open
HaChanho wants to merge 4 commits into
fluent:masterfrom
HaChanho:in_kafka_async_commit
Open

in_kafka: Add async_commit description#1385
HaChanho wants to merge 4 commits into
fluent:masterfrom
HaChanho:in_kafka_async_commit

Conversation

@HaChanho
Copy link
Copy Markdown

@HaChanho HaChanho commented May 30, 2024

Corresponding PR is: fluent/fluent-bit#8894

Summary by CodeRabbit

  • Documentation
    • Updated Kafka input configuration documentation to include a new async_commit parameter for enabling asynchronous commit operations (defaults to false).

Review Change Stack

Signed-off-by: HaChanHo <cksgh3770@naver.com>
Copy link
Copy Markdown
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion to change the language a bit. Thanks!

Comment thread pipeline/inputs/kafka.md Outdated
Co-authored-by: Adam Locke <adam.locke@chronosphere.io>
Signed-off-by: champ-ion <cksgh3770@naver.com>
@HaChanho HaChanho requested a review from lockewritesdocs May 30, 2024 16:25
@lockewritesdocs
Copy link
Copy Markdown
Contributor

When #8894 merges, I'll get this one merged as well. Thanks @HaChanho!

@eschabell
Copy link
Copy Markdown
Collaborator

@HaChanho can you resolve the conflicts here in this PR? I've nudged you on the same for the corresponding code PR fluent/fluent-bit#8894 to see if we can get these merged.

@eschabell eschabell self-assigned this Oct 22, 2025
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor labels Oct 22, 2025
Signed-off-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
@esmerel esmerel dismissed lockewritesdocs’s stale review October 22, 2025 16:48

this has had heavy editing since Adam's request.

@esmerel
Copy link
Copy Markdown
Contributor

esmerel commented Oct 22, 2025

I fixed the conflict and made the addition consistent with our guidelines.

@esmerel esmerel removed conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes labels Oct 22, 2025
@eschabell eschabell added the conflict Waiting on conflict to be resolved by contributor label Dec 3, 2025
Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-requested a review as a code owner May 27, 2026 16:10
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eba04998-8d74-4deb-9512-b541a49ada34

📥 Commits

Reviewing files that changed from the base of the PR and between 5231934 and 8e3e5fd.

📒 Files selected for processing (1)
  • pipeline/inputs/kafka.md

📝 Walkthrough

Walkthrough

The Kafka input documentation table is updated to add a new async_commit boolean configuration parameter (default false) that controls asynchronous commit behavior. The rdkafka.{property} row is reformatted. Both changes remain within the same configuration parameter documentation section.

Changes

Kafka input configuration documentation

Layer / File(s) Summary
Kafka input configuration parameters
pipeline/inputs/kafka.md
Configuration parameter table adds async_commit boolean option for asynchronous Kafka commit operations (default false) and updates the rdkafka.{property} table entry formatting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • fluent/fluent-bit-docs#2269: Modifies pipeline/inputs/kafka.md to standardize Kafka input configuration documentation table entries including rdkafka.{property} formatting.

Suggested labels

4.2.1

Poem

🐰 A kafka stream flows swift and true,
With async commits to see us through,
The table now shines with clearer sight,
Configuration documented right! 📚✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change—adding documentation for the async_commit parameter in the Kafka input plugin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell eschabell removed the conflict Waiting on conflict to be resolved by contributor label May 27, 2026
@eschabell
Copy link
Copy Markdown
Collaborator

@HaChanho fixed the conflict.

Copy link
Copy Markdown
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaChanho just waiting on code PR merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants