in_kafka: Add async_commit description#1385
Conversation
Signed-off-by: HaChanHo <cksgh3770@naver.com>
lockewritesdocs
left a comment
There was a problem hiding this comment.
Left a suggestion to change the language a bit. Thanks!
Co-authored-by: Adam Locke <adam.locke@chronosphere.io> Signed-off-by: champ-ion <cksgh3770@naver.com>
|
When #8894 merges, I'll get this one merged as well. Thanks @HaChanho! |
|
@HaChanho can you resolve the conflicts here in this PR? I've nudged you on the same for the corresponding code PR fluent/fluent-bit#8894 to see if we can get these merged. |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
this has had heavy editing since Adam's request.
|
I fixed the conflict and made the addition consistent with our guidelines. |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Kafka input documentation table is updated to add a new ChangesKafka input configuration documentation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@HaChanho fixed the conflict. |
Corresponding PR is: fluent/fluent-bit#8894
Summary by CodeRabbit
async_commitparameter for enabling asynchronous commit operations (defaults tofalse).