Skip to content

out_s3: document server_side_encryption#1347

Open
msolters wants to merge 3 commits into
fluent:masterfrom
msolters:s3-server-side-encryption
Open

out_s3: document server_side_encryption#1347
msolters wants to merge 3 commits into
fluent:masterfrom
msolters:s3-server-side-encryption

Conversation

@msolters
Copy link
Copy Markdown

@msolters msolters commented Mar 28, 2024

Document a new parameter for the S3 output, server_side_encryption introduced in this fluent-bit PR

Summary by CodeRabbit

  • Documentation
    • Added documentation for the S3 output configuration server_side_encryption parameter, enabling users to specify encryption schemes (AES256 or AWS KMS) for uploaded objects.

Review Change Stack

Document a new parameter for the S3 output, server_side_encryption.

Signed-off-by: Mark Solters <solters@arcesium.com>
@eschabell
Copy link
Copy Markdown
Collaborator

@msolters would you mind resolving the conflicts on this doc PR? I've nudged the team on the corresponding code PR fluent/fluent-bit#8646 to look at why the checks are failing and would like to have this ready to go when the code PR merges.

@eschabell eschabell self-assigned this Oct 22, 2025
@eschabell eschabell requested a review from esmerel October 22, 2025 15:25
@eschabell eschabell added waiting-for-user Waiting for user/contributors feedback or requested changes conflict Waiting on conflict to be resolved by contributor waiting-on-review Waiting on a review from mainteners labels Oct 22, 2025
@eschabell
Copy link
Copy Markdown
Collaborator

@esmerel would you mind reviewing this doc PR?

Signed-off-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
@esmerel
Copy link
Copy Markdown
Contributor

esmerel commented Oct 22, 2025

I fixed the conflict and edited the single line that was changed.

@esmerel esmerel removed conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes waiting-on-review Waiting on a review from mainteners labels Oct 22, 2025
@eschabell eschabell added the conflict Waiting on conflict to be resolved by contributor label Dec 3, 2025
Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-requested a review as a code owner May 27, 2026 16:16
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80c225e0-0fcc-461d-91c4-1b2494a6d603

📥 Commits

Reviewing files that changed from the base of the PR and between 5231934 and c3e648a.

📒 Files selected for processing (1)
  • pipeline/outputs/s3.md

📝 Walkthrough

Walkthrough

Added documentation for the server_side_encryption S3 output configuration parameter, specifying that it controls the server-side encryption scheme for uploaded objects with values like AES256 or aws:kms.

Changes

S3 Encryption Configuration Documentation

Layer / File(s) Summary
S3 server_side_encryption parameter
pipeline/outputs/s3.md
New configuration table row documents server_side_encryption parameter, describing its purpose and supported encryption scheme values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A carrot of docs, so neat and fine,
Encryption schemes in every line,
S3 secrets tucked away,
Safe from prying eyes, hip hooray! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'out_s3: document server_side_encryption' is specific, concise, and clearly describes the main change—documenting a new S3 output parameter.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell eschabell removed the conflict Waiting on conflict to be resolved by contributor label May 27, 2026
@eschabell
Copy link
Copy Markdown
Collaborator

@msolters fixed the conflicts.

Copy link
Copy Markdown
Collaborator

@eschabell eschabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msolters waiting on code PR merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants