Resolving the remote host name to IP only once at startup time.#14
Open
derjohn wants to merge 2 commits intofluent-plugins-nursery:masterfrom
Open
Resolving the remote host name to IP only once at startup time.#14derjohn wants to merge 2 commits intofluent-plugins-nursery:masterfrom
derjohn wants to merge 2 commits intofluent-plugins-nursery:masterfrom
Conversation
|
|
||
| def start | ||
| super | ||
| require 'resolv' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
I'd recommend not making this the default behavior because doesn't honor DNS TTLs. As long as the app runs, the original IP will be used. That's a great hack for someone who is intentionally willing to trade fewer DNS requests for more brittleness, but it's not a great default :) |
houndci-bot
reviewed
Sep 15, 2016
|
|
||
| config_param :host, :string | ||
| config_param :port, :integer, :default => 25 | ||
| config_param :port, :integer, :default => 514 |
Contributor
Author
|
Long open thing? Still valid or #close ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.