Fix timeout logs#121
Open
MarcusKWork wants to merge 3 commits intofluent-plugins-nursery:masterfrom
Open
Conversation
MarcusKWork
force-pushed
the
fix_timeout_logs
branch
from
63a2c52 to
df9c8c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a timeout occured the logs were not emitted properly by the plugin because Fluent::Engine.now allways delivered the same timestamp. Because of that flush_timeout_buffer never did anything. I replaced it with the same call Fluent::Engine.now does in the background and now it works. I also added a test case for that.